You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by jerryshao <gi...@git.apache.org> on 2017/09/20 03:18:10 UTC

[GitHub] spark pull request #19277: [SPARK-22058][CORE]the BufferedInputStream will n...

Github user jerryshao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19277#discussion_r139867369
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala ---
    @@ -351,11 +351,11 @@ private[spark] object EventLoggingListener extends Logging {
         // Since we sanitize the app ID to not include periods, it is safe to split on it
         val logName = log.getName.stripSuffix(IN_PROGRESS)
         val codecName: Option[String] = logName.split("\\.").tail.lastOption
    -    val codec = codecName.map { c =>
    -      codecMap.getOrElseUpdate(c, CompressionCodec.createCodec(new SparkConf, c))
    -    }
    -
    +    
         try {
    +      val codec = codecName.map { c =>
    --- End diff --
    
    Why would here throw an exception?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org