[jira] [Resolved] (FELIX-6162) ConfigurationManager crashes on shutdown if PersistenceManager not yet available

["Carsten Ziegeler (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/FELIX-6162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carsten Ziegeler resolved FELIX-6162.
-------------------------------------
    Resolution: Fixed

Thanks [~tobgun] for reporting, it's now fixed in rev 1863771.

> ConfigurationManager crashes on shutdown if PersistenceManager not yet available
> --------------------------------------------------------------------------------
>
>                 Key: FELIX-6162
>                 URL: https://issues.apache.org/jira/browse/FELIX-6162
>             Project: Felix
>          Issue Type: Bug
>          Components: Configuration Admin
>            Reporter: Tobias Gunkel
>            Assignee: Carsten Ziegeler
>            Priority: Major
>             Fix For: configadmin-1.9.18
>
>
> If ConfigurationManager shuts down, it tries to close the managedServiceFactoryTracker and managedServiceTracker.
> ConfigurationManager.stop():
> {code:java}
>         // stop handling ManagedService[Factory] services
>         managedServiceFactoryTracker.close();
>         managedServiceTracker.close();
> {code}
> In integration tests both services might not available at this time and it crashes:
> {code:java}
> java.lang.NullPointerException
>              at org.apache.felix.cm.impl.ConfigurationManager.stop(ConfigurationManager.java:222)
>              at org.apache.felix.cm.impl.ConfigurationAdminStarter.deactivate(ConfigurationAdminStarter.java:95)
>              at org.apache.felix.cm.impl.DependencyTracker.stop(DependencyTracker.java:112)
>              at org.apache.felix.cm.impl.Activator.stop(Activator.java:160)
>              at org.apache.felix.framework.util.SecureAction.stopActivator(SecureAction.java:720)
>              at org.apache.felix.framework.Felix.stopBundle(Felix.java:2795)
> {code}
> ++
> {code:java}
>              at org.apache.felix.framework.Felix.setActiveStartLevel(Felix.java:1557)
>              at org.apache.felix.framework.FrameworkStartLevelImpl.run(FrameworkStartLevelImpl.java:308)
>              at java.lang.Thread.run(Thread.java:748)
> {code}
> The reason for this is that managedServiceTracker and managedServiceFactoryTracker are assigned *after* service registration of ConfigurationAdmin in the start() method.
>  The integration test is (sometimes) directly run after the bundleContext.registerService(ConfigurationAdmin.class, ...) line. And directly after the integration test execution the Configuration.stop() method is called where it crashes as managedServiceTracker and managedServiceFactoryTracker are still null.
> ConfigurationManager.start():
> {code:java}
>         configurationAdminRegistration = bundleContext.registerService(ConfigurationAdmin.class, caf,
>                 serviceProperties);
>         // start handling ManagedService[Factory] services
>         managedServiceTracker = new ManagedServiceTracker(this);
>         managedServiceFactoryTracker = new ManagedServiceFactoryTracker(this);
> {code}
> Although this sounds like a rare race-condition, it is reproducible in our test environment. About 30% of the tests fail with the above exception.
> A simple solution would be to just add null-checks (as with every other service that is accessed in the stop() method):
>  ConfigurationManager.stop():
> {code:java}
>         // stop handling ManagedService[Factory] services
>         if (managedServiceFactoryTracker != null)
>         {
>             managedServiceFactoryTracker.close();
>         }
>         if (managedServiceTracker != null)
>         {
>             managedServiceTracker.close();
>         }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)