[GitHub] TaoLv commented on a change in pull request #13576: [MXNET-679] Improved CMakeLists.txt

[GitBox <gi...@apache.org>]

TaoLv commented on a change in pull request #13576: [MXNET-679] Improved CMakeLists.txt
URL: https://github.com/apache/incubator-mxnet/pull/13576#discussion_r240007026
 
 

 ##########
 File path: cmake/cmake_options.yml
 ##########
 @@ -26,7 +26,7 @@ USE_SSE: "ON" # Build with x86 SSE instruction support IF NOT ARM
 USE_F16C: "ON" # Build with x86 F16C instruction support) # autodetects support if "ON"
 USE_LAPACK: "ON" # Build with lapack support
 USE_MKL_IF_AVAILABLE: "ON" # Use MKL if found
-USE_MKLML_MKL: "ON" # Use MKLDNN variant of MKL (if MKL found) IF USE_MKL_IF_AVAILABLE AND (NOT APPLE)
+USE_MKLML: "ON" # Use MKLDNN variant of MKL (if MKL found) IF USE_MKL_IF_AVAILABLE AND (NOT APPLE)
 
 Review comment:
   Agree that compatibility is more important, although `USE_MKLML_MKL` is really redundant for me. Is it possible to give a warning message if `USE_MKLML_MKL` is provided and set its value to USE_MKLML? And remove this warning message and `USE_MKLML_MKL` totally in a major release?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services