You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Jaimin Jetly <ja...@hortonworks.com> on 2017/01/30 21:30:03 UTC

Review Request 56097: Need to have a flag from UI to show/hide ranger plugin configs

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56097/
-----------------------------------------------------------

Review request for Ambari, Richard Zang, Xi Wang, and Yusaku Sako.


Bugs: AMBARI-19785
    https://issues.apache.org/jira/browse/AMBARI-19785


Repository: ambari


Description
-------

UI changes are required to show/hide ranger plugin configs under component config tab.

If Ranger is not installed on same cluster but is setup on external cluster then cluster-env/enable_external_ranger can be set to true to expose ranger plugin related properties for all services

This Flag *cluster-env/enable_external_range* should show ranger plugin config-types for all services:
ranger-<component>-plugin-properties.xml
ranger-<component>-audit.xml
ranger-<component>-security.xml
ranger-<component>-policymgr-ssl.xml


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml 93680bf 
  ambari-web/app/controllers/main/service/info/configs.js d946ea0 
  ambari-web/app/controllers/wizard/step7_controller.js 7dcc2ad 

Diff: https://reviews.apache.org/r/56097/diff/


Testing
-------

Verified on manual cluster
verified that all ambari-web unit tests passes:

20325 passing (24s)
153 pending


Thanks,

Jaimin Jetly


Re: Review Request 56097: Need to have a flag from UI to show/hide ranger plugin configs

Posted by Jaimin Jetly <ja...@hortonworks.com>.

> On Jan. 31, 2017, 6:46 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml, line 293
> > <https://reviews.apache.org/r/56097/diff/1/?file=1619361#file1619361line293>
> >
> >     This is also needed in cluster-env for HDP 3.0

Thanks for letting me know.
Fixed it as part of addendum patch


- Jaimin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56097/#review163691
-----------------------------------------------------------


On Jan. 30, 2017, 9:30 p.m., Jaimin Jetly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56097/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2017, 9:30 p.m.)
> 
> 
> Review request for Ambari, Richard Zang, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-19785
>     https://issues.apache.org/jira/browse/AMBARI-19785
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> UI changes are required to show/hide ranger plugin configs under component config tab.
> 
> If Ranger is not installed on same cluster but is setup on external cluster then cluster-env/enable_external_ranger can be set to true to expose ranger plugin related properties for all services
> 
> This Flag *cluster-env/enable_external_range* should show ranger plugin config-types for all services:
> ranger-<component>-plugin-properties.xml
> ranger-<component>-audit.xml
> ranger-<component>-security.xml
> ranger-<component>-policymgr-ssl.xml
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml 93680bf 
>   ambari-web/app/controllers/main/service/info/configs.js d946ea0 
>   ambari-web/app/controllers/wizard/step7_controller.js 7dcc2ad 
> 
> Diff: https://reviews.apache.org/r/56097/diff/
> 
> 
> Testing
> -------
> 
> Verified on manual cluster
> verified that all ambari-web unit tests passes:
> 
> 20325 passing (24s)
> 153 pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>


Re: Review Request 56097: Need to have a flag from UI to show/hide ranger plugin configs

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56097/#review163691
-----------------------------------------------------------


Fix it, then Ship it!





ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml (line 293)
<https://reviews.apache.org/r/56097/#comment235168>

    This is also needed in cluster-env for HDP 3.0


- Alejandro Fernandez


On Jan. 30, 2017, 9:30 p.m., Jaimin Jetly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56097/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2017, 9:30 p.m.)
> 
> 
> Review request for Ambari, Richard Zang, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-19785
>     https://issues.apache.org/jira/browse/AMBARI-19785
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> UI changes are required to show/hide ranger plugin configs under component config tab.
> 
> If Ranger is not installed on same cluster but is setup on external cluster then cluster-env/enable_external_ranger can be set to true to expose ranger plugin related properties for all services
> 
> This Flag *cluster-env/enable_external_range* should show ranger plugin config-types for all services:
> ranger-<component>-plugin-properties.xml
> ranger-<component>-audit.xml
> ranger-<component>-security.xml
> ranger-<component>-policymgr-ssl.xml
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml 93680bf 
>   ambari-web/app/controllers/main/service/info/configs.js d946ea0 
>   ambari-web/app/controllers/wizard/step7_controller.js 7dcc2ad 
> 
> Diff: https://reviews.apache.org/r/56097/diff/
> 
> 
> Testing
> -------
> 
> Verified on manual cluster
> verified that all ambari-web unit tests passes:
> 
> 20325 passing (24s)
> 153 pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>


Re: Review Request 56097: Need to have a flag from UI to show/hide ranger plugin configs

Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56097/#review163685
-----------------------------------------------------------


Ship it!




Ship It!

- Yusaku Sako


On Jan. 30, 2017, 9:30 p.m., Jaimin Jetly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56097/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2017, 9:30 p.m.)
> 
> 
> Review request for Ambari, Richard Zang, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-19785
>     https://issues.apache.org/jira/browse/AMBARI-19785
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> UI changes are required to show/hide ranger plugin configs under component config tab.
> 
> If Ranger is not installed on same cluster but is setup on external cluster then cluster-env/enable_external_ranger can be set to true to expose ranger plugin related properties for all services
> 
> This Flag *cluster-env/enable_external_range* should show ranger plugin config-types for all services:
> ranger-<component>-plugin-properties.xml
> ranger-<component>-audit.xml
> ranger-<component>-security.xml
> ranger-<component>-policymgr-ssl.xml
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml 93680bf 
>   ambari-web/app/controllers/main/service/info/configs.js d946ea0 
>   ambari-web/app/controllers/wizard/step7_controller.js 7dcc2ad 
> 
> Diff: https://reviews.apache.org/r/56097/diff/
> 
> 
> Testing
> -------
> 
> Verified on manual cluster
> verified that all ambari-web unit tests passes:
> 
> 20325 passing (24s)
> 153 pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>