[jira] [Commented] (CXF-6480) InjectionUtils createThreadLocalServletApiContext better error message for invalid @Context classes

["Sergey Beryozkin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CXF-6480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14609079#comment-14609079 ] 

Sergey Beryozkin commented on CXF-6480:
---------------------------------------

Which CXF version is it ? 

> InjectionUtils createThreadLocalServletApiContext better error message for invalid @Context classes
> ---------------------------------------------------------------------------------------------------
>
>                 Key: CXF-6480
>                 URL: https://issues.apache.org/jira/browse/CXF-6480
>             Project: CXF
>          Issue Type: Bug
>            Reporter: Ravi Luthra
>            Priority: Trivial
>
> When you have an \@Context field in a JAXRS class (maybe JAXWS too?) there is a select list of possible proxy classes. This method checks for the proxy class using an if/else/if/else... structure, but there is no final else clause with a good exception. Instead the method attempts to instantiate a null class name (proxyClassName), which throws a NullPointerException. This leaves the method wrapped inside a RuntimeException. A common forgetful change someone might make is to add
> {code}@Context private HttpSession session; //(instead of private HttpServletRequest){code}
> Which leaves a massive stack trace leaving just an NPE and Spring also tends to obscure the stack-trace of this issue. A better error would be to suggest that the given class ...HttpSession is not a valid Context type. No proxy classes can be created for this type.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)