You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by se...@apache.org on 2004/02/22 15:36:46 UTC
cvs commit: jakarta-jmeter/src/core/org/apache/jmeter/samplers SampleResult.java
sebb 2004/02/22 06:36:46
Modified: src/core/org/apache/jmeter/samplers SampleResult.java
Log:
Add comments to some fields; fix default encoding from 8895-1 to ISO-8895-1
Revision Changes Path
1.27 +7 -6 jakarta-jmeter/src/core/org/apache/jmeter/samplers/SampleResult.java
Index: SampleResult.java
===================================================================
RCS file: /home/cvs/jakarta-jmeter/src/core/org/apache/jmeter/samplers/SampleResult.java,v
retrieving revision 1.26
retrieving revision 1.27
diff -u -r1.26 -r1.27
--- SampleResult.java 13 Feb 2004 02:40:53 -0000 1.26
+++ SampleResult.java 22 Feb 2004 14:36:46 -0000 1.27
@@ -72,7 +72,7 @@
private String threadName;
private String responseMessage="";
private String responseHeaders=""; // Never return null
- private String contentType;
+ private String contentType; // e.g. text/html; charset=utf-8
private String requestHeaders="";
private long timeStamp = 0;// the time stamp - can be start or end
private long startTime = 0;
@@ -84,10 +84,11 @@
private String dataType;
private boolean success;
private Set files;
- private String dataEncoding;
+ private String dataEncoding;// (is this really the character set?) e.g. ISO-8895-1, UTF-8
private long time = 0;
private boolean stopThread = false; //Should thread terminate?
private boolean stopTest = false; //Should test terminate?
+ //TODO do contentType and/or dataEncoding belong in HTTPSampleResult instead?
private final static String TOTAL_TIME = "totalTime";
@@ -418,13 +419,13 @@
}
else
{
- return "8859-1";
+ return "ISO-8859-1";// 8859-1 is not a valid Java data encoding ..
}
}
/**
* Sets the dataEncoding.
- * @param dataEncoding the dataEncoding to set
+ * @param dataEncoding the dataEncoding to set, e.g. ISO-8895-1, UTF-8
*/
public void setDataEncoding(String dataEncoding)
{
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org