You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/01/16 16:59:01 UTC

[GitHub] codecov-io commented on issue #6618: Support preselect_filters without filter_box IDs

codecov-io commented on issue #6618: Support preselect_filters without filter_box IDs
URL: https://github.com/apache/incubator-superset/pull/6618#issuecomment-454856198
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6618?src=pr&el=h1) Report
   > Merging [#6618](https://codecov.io/gh/apache/incubator-superset/pull/6618?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/4c658444e4b5835e2069851863719d4f3aeb7d5a?src=pr&el=desc) will **increase** coverage by `0.3%`.
   > The diff coverage is `97.29%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/6618/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/6618?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##           master    #6618     +/-   ##
   =========================================
   + Coverage   56.19%   56.49%   +0.3%     
   =========================================
     Files         520      521      +1     
     Lines       23181    23201     +20     
     Branches     2765     2770      +5     
   =========================================
   + Hits        13027    13108     +81     
   + Misses       9744     9690     -54     
   + Partials      410      403      -7
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/6618?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [.../assets/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/6618/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9GaWx0ZXJCb3gvRmlsdGVyQm94LmpzeA==) | `0% <0%> (ø)` | :arrow_up: |
   | [...uperset/assets/src/dashboard/util/filterOptions.js](https://codecov.io/gh/apache/incubator-superset/pull/6618/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvdXRpbC9maWx0ZXJPcHRpb25zLmpz) | `100% <100%> (ø)` | |
   | [...t/assets/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/6618/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | `94.36% <100%> (+94.36%)` | :arrow_up: |
   | [...erset/assets/src/dashboard/util/getDashboardUrl.js](https://codecov.io/gh/apache/incubator-superset/pull/6618/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvdXRpbC9nZXREYXNoYm9hcmRVcmwuanM=) | `100% <100%> (ø)` | :arrow_up: |
   | [...perset/assets/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/6618/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvdXRpbC9nZXRFbXB0eUxheW91dC5qcw==) | `100% <0%> (+100%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6618?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6618?src=pr&el=footer). Last update [4c65844...9d8d910](https://codecov.io/gh/apache/incubator-superset/pull/6618?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org