You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/05/15 19:59:29 UTC
[GitHub] [beam] robertwb commented on a change in pull request #11720: [BEAM-9729] Ignore bundle registration requests.
robertwb commented on a change in pull request #11720:
URL: https://github.com/apache/beam/pull/11720#discussion_r426018974
##########
File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnHarness.java
##########
@@ -206,18 +205,16 @@ public static void main(
LoadingCache<String, BeamFnApi.ProcessBundleDescriptor> processBundleDescriptors =
CacheBuilder.newBuilder()
+ .maximumSize(1000)
+ .expireAfterAccess(10, TimeUnit.MINUTES)
.build(
new CacheLoader<String, BeamFnApi.ProcessBundleDescriptor>() {
@Override
public BeamFnApi.ProcessBundleDescriptor load(String id) {
- try {
- return blockingControlStub.getProcessBundleDescriptor(
- BeamFnApi.GetProcessBundleDescriptorRequest.newBuilder()
- .setProcessBundleDescriptorId(id)
- .build());
- } catch (Throwable th) {
- return (BeamFnApi.ProcessBundleDescriptor) fnApiRegistry.getById(id);
Review comment:
All runners now support the pull protocol.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org