You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2017/02/14 10:09:15 UTC
Review Request 56649: LENS-1387: Move Lens to java 8
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56649/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-1387
https://issues.apache.org/jira/browse/LENS-1387
Repository: lens
Description
-------
Deprecating java7 and restricting lens to only compile with java 8 +
Diffs
-----
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 9b290832f2ae0072c5d1b3abd387d6e674ce72e7
pom.xml 8ea64b77fff11d9f46be56437aed3b527bde0ff8
Diff: https://reviews.apache.org/r/56649/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 56649: LENS-1387: Move Lens to java 8
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56649/#review165656
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On Feb. 15, 2017, 5:54 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56649/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2017, 5:54 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1387
> https://issues.apache.org/jira/browse/LENS-1387
>
>
> Repository: lens
>
>
> Description
> -------
>
> Deprecating java7 and restricting lens to only compile with java 8 +
>
>
> Diffs
> -----
>
> pom.xml 8ea64b77fff11d9f46be56437aed3b527bde0ff8
>
> Diff: https://reviews.apache.org/r/56649/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 56649: LENS-1387: Move Lens to java 8
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56649/
-----------------------------------------------------------
(Updated Feb. 15, 2017, 11:24 a.m.)
Review request for lens.
Bugs: LENS-1387
https://issues.apache.org/jira/browse/LENS-1387
Repository: lens
Description
-------
Deprecating java7 and restricting lens to only compile with java 8 +
Diffs (updated)
-----
pom.xml 8ea64b77fff11d9f46be56437aed3b527bde0ff8
Diff: https://reviews.apache.org/r/56649/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 56649: LENS-1387: Move Lens to java 8
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On Feb. 15, 2017, 9 a.m., Puneet Gupta wrote:
> > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java, line 2713
> > <https://reviews.apache.org/r/56649/diff/1/?file=1633075#file1633075line2713>
> >
> > Is this chnage required for java 8 ?
No. I was seeing some setup issue on my local machine in cube tests. This seemed to fix it. But this causes failure in two other tests. Hence, reverted.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56649/#review165639
-----------------------------------------------------------
On Feb. 15, 2017, 11:24 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56649/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2017, 11:24 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1387
> https://issues.apache.org/jira/browse/LENS-1387
>
>
> Repository: lens
>
>
> Description
> -------
>
> Deprecating java7 and restricting lens to only compile with java 8 +
>
>
> Diffs
> -----
>
> pom.xml 8ea64b77fff11d9f46be56437aed3b527bde0ff8
>
> Diff: https://reviews.apache.org/r/56649/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 56649: LENS-1387: Move Lens to java 8
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56649/#review165639
-----------------------------------------------------------
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java
<https://reviews.apache.org/r/56649/#comment237502>
Is this chnage required for java 8 ?
- Puneet Gupta
On Feb. 14, 2017, 10:09 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56649/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2017, 10:09 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1387
> https://issues.apache.org/jira/browse/LENS-1387
>
>
> Repository: lens
>
>
> Description
> -------
>
> Deprecating java7 and restricting lens to only compile with java 8 +
>
>
> Diffs
> -----
>
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 9b290832f2ae0072c5d1b3abd387d6e674ce72e7
> pom.xml 8ea64b77fff11d9f46be56437aed3b527bde0ff8
>
> Diff: https://reviews.apache.org/r/56649/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>