[GitHub] jihoonson commented on a change in pull request #6690: bugfix: when building materialized-view, if taskCount>1, may cause concurrentModificationException

[GitBox <gi...@apache.org>]

jihoonson commented on a change in pull request #6690: bugfix: when building materialized-view, if taskCount>1, may cause concurrentModificationException
URL: https://github.com/apache/incubator-druid/pull/6690#discussion_r257423882
 
 

 ##########
 File path: extensions-contrib/materialized-view-maintenance/src/test/java/org/apache/druid/indexing/materializedview/MaterializedViewSupervisorTest.java
 ##########
 @@ -176,6 +176,29 @@ public void testCheckSegments() throws IOException
     Assert.assertEquals(expectedSegments, toBuildInterval.rhs);
   }
 
+  @Test
+  public void testCheckSegmentsAndSubmitTasks() throws IOException
 
 Review comment:
   I don't think this test checks your change because there's no running tasks. I think the easiest way is to add a method annotated by `@VisibleForTesting` which updates `runningTasks` and calls `checkSegmentsAndSubmitTasks()`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org