You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2020/07/29 17:37:36 UTC

[GitHub] [guacamole-client] rwanito opened a new pull request #556: Add ldap-member-attribute-type support for Docker

rwanito opened a new pull request #556:
URL: https://github.com/apache/guacamole-client/pull/556


   Hi !
   
   I need to add this variable to my docker-compose file to use my ldap.
   So, I think i'm not alone, so I suggest to add it.
   
   Maybe, it will be useful to add other variable like : 
   
   ldap-dereference-aliases
   ldap-follow-referrals
   ldap-max-referral-hops
   ldap-operation-timeout
   
   Thanks for your work !


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [guacamole-client] rwanito commented on pull request #556: GUACAMOLE-1147: Add ldap-member-attribute-type support for Docker

Posted by GitBox <gi...@apache.org>.
rwanito commented on pull request #556:
URL: https://github.com/apache/guacamole-client/pull/556#issuecomment-668177797


   Hi ! I commited my changes about the spacing et style.
   Normally, now there is all ldap attributes from the doc in the start.sh.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [guacamole-client] rwanito commented on pull request #556: GUACAMOLE-1147: Add ldap-member-attribute-type support for Docker

Posted by GitBox <gi...@apache.org>.
rwanito commented on pull request #556:
URL: https://github.com/apache/guacamole-client/pull/556#issuecomment-665678269


   Thanks for your reply.
   Is it ok, now ?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [guacamole-client] necouchman commented on a change in pull request #556: GUACAMOLE-1147: Add ldap-member-attribute-type support for Docker

Posted by GitBox <gi...@apache.org>.
necouchman commented on a change in pull request #556:
URL: https://github.com/apache/guacamole-client/pull/556#discussion_r462376299



##########
File path: guacamole-docker/bin/start.sh
##########
@@ -438,6 +438,7 @@ END
     set_optional_property "ldap-user-search-filter" "$LDAP_USER_SEARCH_FILTER"
     set_optional_property "ldap-config-base-dn"     "$LDAP_CONFIG_BASE_DN"
     set_optional_property "ldap-group-base-dn"      "$LDAP_GROUP_BASE_DN"
+    set_optional_property "ldap-member-attribute-type"   "$LDAP_MEMBER_ATTRIBUTE_TYPE"

Review comment:
       Probably makes sense to line up the spacing on these lines so that the final column all starts in the same place.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [guacamole-client] necouchman commented on pull request #556: Add ldap-member-attribute-type support for Docker

Posted by GitBox <gi...@apache.org>.
necouchman commented on pull request #556:
URL: https://github.com/apache/guacamole-client/pull/556#issuecomment-665661101


   @rwanito: Thanks for the contribution.  However, in order for us to work through this you will first need to open a JIRA issue for the changes:
   
   https://issues.apache.org/jira/browse/GUACAMOLE
   
   After that you'll need to tag both the pull request and commit message(s) with the JIRA issue.  Full contribution guidelines can be found, here:
   
   http://guacamole.apache.org/open-source/


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [guacamole-client] necouchman merged pull request #556: GUACAMOLE-1147: Add support for additional LDAP properties in Docker container

Posted by GitBox <gi...@apache.org>.
necouchman merged pull request #556:
URL: https://github.com/apache/guacamole-client/pull/556


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org