[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #31553: Fix sorting of tags

["pierrejeambrun (via GitHub)" <gi...@apache.org>]

pierrejeambrun commented on code in PR #31553:
URL: https://github.com/apache/airflow/pull/31553#discussion_r1205931887


##########
airflow/www/templates/airflow/dags.html:
##########
@@ -159,7 +159,7 @@ <h2>{{ page_title }}</h2>
         <form id="tags_form">
           <div class="form-group search-input">
             <select multiple name="tags" id="tags_filter" class="select2-drop-mask">
-              {% for tag in tags %}
+              {% for tag in tags.sort() %}

Review Comment:
   This will sort but there is no key specified, will this sort on the DagTag.id ? Is it what we want, maybe the name is more relevant ? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org