[GitHub] [incubator-ratis] joshelser commented on a change in pull request #18: RATIS-523 RATIS-524 RATIS-525 RATIS-526 RATIS-527 RATIS-533 Lots of cleanup on the LogService

[GitBox <gi...@apache.org>]

joshelser commented on a change in pull request #18: RATIS-523 RATIS-524 RATIS-525 RATIS-526 RATIS-527 RATIS-533 Lots of cleanup on the LogService
URL: https://github.com/apache/incubator-ratis/pull/18#discussion_r280555991
 
 

 ##########
 File path: ratis-logservice/src/main/java/org/apache/ratis/logservice/server/LogServer.java
 ##########
 @@ -61,13 +64,31 @@ public static Builder newBuilder() {
         return new Builder();
     }
 
+    @Override
+    void setRaftProperties(RaftProperties properties) {
+      super.setRaftProperties(properties);
+
+      // Increase the client timeout
+      RaftClientConfigKeys.Rpc.setRequestTimeout(properties, TimeDuration.valueOf(100, TimeUnit.SECONDS));
+
+      // Increase the segment size to avoid rolling so quickly
+      SizeInBytes segmentSize = SizeInBytes.valueOf("32MB");
 
 Review comment:
   This one was weird. I was playing with making it configurable, but changes to it had some _really_ harmful implications (things were just hanging when I increased this, for example).
   
   I left it here as something for us to come back to later, but not something I wanted to have people tweak. Maybe it's OK to still let this be configurable? (with a big-fat-warning :P)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services