[GitHub] [orc] dongjoon-hyun commented on a change in pull request #718: ORC-815: Build and test C++ module on CLang12

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #718:
URL: https://github.com/apache/orc/pull/718#discussion_r650449570



##########
File path: CMakeLists.txt
##########
@@ -98,7 +98,7 @@ if (CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
   set (WARN_FLAGS "${WARN_FLAGS} -Wno-gnu-zero-variadic-macro-arguments")
   set (WARN_FLAGS "${WARN_FLAGS} -Wconversion")
   if (CMAKE_HOST_APPLE AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER "11.0")
-    set (WARN_FLAGS "${WARN_FLAGS} -Wno-c++2a-compat")
+    set (WARN_FLAGS "${WARN_FLAGS} -Wno-c++2a-compat -Wno-suggest-override -Wno-suggest-destructor-override")
   endif ()

Review comment:
       Maybe, shall we change like this?
   ```
   -  if (CMAKE_HOST_APPLE AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER "11.0")
   +  if (CMAKE_HOST_APPLE AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER "12.0")
   +    set (WARN_FLAGS "${WARN_FLAGS} -Wno-c++2a-compat -Wno-suggest-override -Wno-suggest-destructor-override")
   +  elseif (CMAKE_HOST_APPLE AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER "11.0")
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org