Re: vsn-rsc-url adaptations

[Ben Collins-Sussman <su...@collab.net>]

Greg Stein <gs...@lyra.org> writes:

> Ah... You're sending "18.1" and the atoi() in your code is translating that
> as revision 18. That isn't going to work so well :-)
> 
> So there are two things to do:
> 
> 1) SVN_STR_TO_REV(const char *) ought to have a companion that will take a
>    ptr/len pair and convert the whole thing (and produce an error if the
>    entire text is not consumed).

Do we really need to file an issue on this?  I mean, as long as
revisions remain integers, we're okay.  Do we expect float-strings to
be thrown at SVN_STR_TO_REV anytime?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: vsn-rsc-url adaptations

[Greg Stein <gs...@lyra.org>]

On Wed, Jun 05, 2002 at 03:30:59PM -0500, Ben Collins-Sussman wrote:
> Greg Stein <gs...@lyra.org> writes:
> 
> > Ah... You're sending "18.1" and the atoi() in your code is translating that
> > as revision 18. That isn't going to work so well :-)
> > 
> > So there are two things to do:
> > 
> > 1) SVN_STR_TO_REV(const char *) ought to have a companion that will take a
> >    ptr/len pair and convert the whole thing (and produce an error if the
> >    entire text is not consumed).
> 
> Do we really need to file an issue on this?  I mean, as long as
> revisions remain integers, we're okay.  Do we expect float-strings to
> be thrown at SVN_STR_TO_REV anytime?

It really depends on how anal we want to be in the URLs that we accept.
Personally, I'd prefer that people aren't allowed to send illegal URLs. But
it does mean some extra work. Filing an issue might be nice, but low
priority...

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org