You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by jl...@apache.org on 2009/11/25 23:55:29 UTC

svn commit: r884325 - /ofbiz/trunk/specialpurpose/shark/src/org/ofbiz/shark/repository/EntityRepositoryMgr.java

Author: jleroux
Date: Wed Nov 25 22:55:29 2009
New Revision: 884325

URL: http://svn.apache.org/viewvc?rev=884325&view=rev
Log:
Oops fix r884308 (missed the >0 part when replacing xpdls != null && xpdls.size() > 0 by UtilValidate.isNotEmpty(xpdls)

Modified:
    ofbiz/trunk/specialpurpose/shark/src/org/ofbiz/shark/repository/EntityRepositoryMgr.java

Modified: ofbiz/trunk/specialpurpose/shark/src/org/ofbiz/shark/repository/EntityRepositoryMgr.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/shark/src/org/ofbiz/shark/repository/EntityRepositoryMgr.java?rev=884325&r1=884324&r2=884325&view=diff
==============================================================================
--- ofbiz/trunk/specialpurpose/shark/src/org/ofbiz/shark/repository/EntityRepositoryMgr.java (original)
+++ ofbiz/trunk/specialpurpose/shark/src/org/ofbiz/shark/repository/EntityRepositoryMgr.java Wed Nov 25 22:55:29 2009
@@ -177,7 +177,7 @@
 
     public boolean doesXPDLExist(RepositoryTransaction t, String xpdlId) throws RepositoryException {
         List xpdls = this.getXpdlValues(xpdlId, null, false);
-        Debug.log("Does XPDL [" + xpdlId + "] Exist - " + xpdls + "(" + (UtilValidate.isNotEmpty(xpdls) > 0 ? true : false) + ")", module);
+        Debug.log("Does XPDL [" + xpdlId + "] Exist - " + xpdls + "(" + (UtilValidate.isNotEmpty(xpdls) ? true : false) + ")", module);
         return (UtilValidate.isNotEmpty(xpdls) ? true : false);
     }

Re: svn commit: r884325 - /ofbiz/trunk/specialpurpose/shark/src/org/ofbiz/shark/repository/EntityRepositoryMgr.java

Posted by Adam Heath <do...@brainfood.com>.
jleroux@apache.org wrote:
> Author: jleroux
> Date: Wed Nov 25 22:55:29 2009
> New Revision: 884325
> 
> URL: http://svn.apache.org/viewvc?rev=884325&view=rev
> Log:
> Oops fix r884308 (missed the >0 part when replacing xpdls != null && xpdls.size() > 0 by UtilValidate.isNotEmpty(xpdls)
> 
> Modified:
>     ofbiz/trunk/specialpurpose/shark/src/org/ofbiz/shark/repository/EntityRepositoryMgr.java
> 
> Modified: ofbiz/trunk/specialpurpose/shark/src/org/ofbiz/shark/repository/EntityRepositoryMgr.java
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/shark/src/org/ofbiz/shark/repository/EntityRepositoryMgr.java?rev=884325&r1=884324&r2=884325&view=diff
> ==============================================================================
> --- ofbiz/trunk/specialpurpose/shark/src/org/ofbiz/shark/repository/EntityRepositoryMgr.java (original)
> +++ ofbiz/trunk/specialpurpose/shark/src/org/ofbiz/shark/repository/EntityRepositoryMgr.java Wed Nov 25 22:55:29 2009
> @@ -177,7 +177,7 @@
>  
>      public boolean doesXPDLExist(RepositoryTransaction t, String xpdlId) throws RepositoryException {
>          List xpdls = this.getXpdlValues(xpdlId, null, false);
> -        Debug.log("Does XPDL [" + xpdlId + "] Exist - " + xpdls + "(" + (UtilValidate.isNotEmpty(xpdls) > 0 ? true : false) + ")", module);
> +        Debug.log("Does XPDL [" + xpdlId + "] Exist - " + xpdls + "(" + (UtilValidate.isNotEmpty(xpdls) ? true : false) + ")", module);
>          return (UtilValidate.isNotEmpty(xpdls) ? true : false);

You don't need the ?true:false part either.