[jira] [Commented] (SAMZA-1461) Expose RocksDB properties as metrics

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SAMZA-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16204851#comment-16204851 ] 

ASF GitHub Bot commented on SAMZA-1461:
---------------------------------------

GitHub user janeklb opened a pull request:

    https://github.com/apache/samza/pull/327

    SAMZA-1461 : Expose RocksDB properties as metrics

    Automatically build gauges for RocksDB properties via configuration:
    `stores.<storename>.rocksdb.telemetry.list=<rocksDbProperty1>, <rocksDbProperty1>`

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/janeklb/samza jlb_rocksDBPropertiesAsMetrics

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/327.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #327
    
----
commit e5c39e3e6e61132f96db3ddfb5fc79b0f5a7ea98
Author: Janek Lasocki-Biczysko <ja...@skyscanner.net>
Date:   2017-10-14T22:48:30Z

    Expose RocksDB properties as metrics
    
    Automatically build gauges for RocksDB properties via configuration:
    stores.<storename>.rocksdb.telemetry.list=<rocksDbProperty1>, <rocksDbProperty1>

----


> Expose RocksDB properties as metrics
> ------------------------------------
>
>                 Key: SAMZA-1461
>                 URL: https://issues.apache.org/jira/browse/SAMZA-1461
>             Project: Samza
>          Issue Type: Improvement
>          Components: kv
>            Reporter: Janek Lasocki-Biczysko
>
> RocksDB can expose some relatively useful figures via its 'getProperty' API. Some of them are documented on the [FAQs|https://github.com/facebook/rocksdb/wiki/RocksDB-FAQ] (eg. {{rocksdb.estimate-num-keys}} or {{rocksdb.estimate-live-data-size}}).
> It would be nice to be able to expose these via Samza metrics.
> There isn't a documented list of all the properties, but they're all visible in the source [here|https://github.com/facebook/rocksdb/blob/master/db/internal_stats.cc#L190].



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)