You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Ivan Popov (JIRA)" <ji...@apache.org> on 2007/04/16 15:07:15 UTC

[jira] Created: (HARMONY-3660) [jdktools][jpda] fix JDWP test org.apache.harmony.jpda.tests.jdwp.ThreadReference.FramesTest

[jdktools][jpda] fix JDWP test org.apache.harmony.jpda.tests.jdwp.ThreadReference.FramesTest
--------------------------------------------------------------------------------------------

                 Key: HARMONY-3660
                 URL: https://issues.apache.org/jira/browse/HARMONY-3660
             Project: Harmony
          Issue Type: Bug
          Components: JDK
         Environment: Windows, Linux, apache-harmony-jdk-r529142
            Reporter: Ivan Popov


The following JDWP tests

  org.apache.harmony.jpda.tests.jdwp.ThreadReference.FramesTest

is incorrect and should be fixed.

The problem is that it uses 0 as an invalid value for index of a stack frame while searching for particular frame and thus may find not all frames. This leads to such diagnostics:

----------------------------------------
==> testFrames001 START 
[SYNC] Waiting...
STDOUT> [SYNC] Attached socket
STDOUT> invoke tested method: depth=1
STDOUT> invoke tested method: depth=2
STDOUT> invoke tested method: depth=3
STDOUT> invoke tested method: depth=4
STDOUT> invoke tested method: depth=5
STDOUT> invoke tested method: depth=6
STDOUT> invoke tested method: depth=7
STDOUT> invoke tested method: depth=8
STDOUT> invoke tested method: depth=9
STDOUT> sending SGNL_READY signal
[SYNC] received message: main
==> testedThreadName = |main|
STDOUT> [SYNC] Message sent: main
==> threadID = 1828
startFrame=0; length=-1
framesCount=13
0. frameID=1 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(83)
1. frameID=2 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
2. frameID=3 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
3. frameID=4 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
4. frameID=5 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
5. frameID=6 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
6. frameID=7 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
7. frameID=8 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
8. frameID=9 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
9. frameID=10 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
10. frameID=11 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;run(12)
11. frameID=12 - Lorg/apache/harmony/jpda/tests/share/Debuggee;runDebuggee(49)
12. frameID=13 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;main(4)
startFrame=1; length=-1
framesCount=12
1. frameID=2 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
2. frameID=3 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
3. frameID=4 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
4. frameID=5 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
5. frameID=6 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
6. frameID=7 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
7. frameID=8 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
8. frameID=9 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
9. frameID=10 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
10. frameID=11 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;run(12)
11. frameID=12 - Lorg/apache/harmony/jpda/tests/share/Debuggee;runDebuggee(49)
12. frameID=13 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;main(4)
# ERROR: Number of recursiveMethod in frames 9 but expected 10
[SYNC] Message sent: continue
==> testFrames001 FAILED 
----------------------------------------


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HARMONY-3660) [jdktools][jpda] fix JDWP test org.apache.harmony.jpda.tests.jdwp.ThreadReference.FramesTest

Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gregory Shimansky reassigned HARMONY-3660:
------------------------------------------

    Assignee: Gregory Shimansky

> [jdktools][jpda] fix JDWP test org.apache.harmony.jpda.tests.jdwp.ThreadReference.FramesTest
> --------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-3660
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3660
>             Project: Harmony
>          Issue Type: Bug
>          Components: JDK
>         Environment: Windows, Linux, apache-harmony-jdk-r529142
>            Reporter: Ivan Popov
>         Assigned To: Gregory Shimansky
>         Attachments: H3660-fix_test.patch
>
>
> The following JDWP tests
>   org.apache.harmony.jpda.tests.jdwp.ThreadReference.FramesTest
> is incorrect and should be fixed.
> The problem is that it uses 0 as an invalid value for index of a stack frame while searching for particular frame and thus may find not all frames. This leads to such diagnostics:
> ----------------------------------------
> ==> testFrames001 START 
> [SYNC] Waiting...
> STDOUT> [SYNC] Attached socket
> STDOUT> invoke tested method: depth=1
> STDOUT> invoke tested method: depth=2
> STDOUT> invoke tested method: depth=3
> STDOUT> invoke tested method: depth=4
> STDOUT> invoke tested method: depth=5
> STDOUT> invoke tested method: depth=6
> STDOUT> invoke tested method: depth=7
> STDOUT> invoke tested method: depth=8
> STDOUT> invoke tested method: depth=9
> STDOUT> sending SGNL_READY signal
> [SYNC] received message: main
> ==> testedThreadName = |main|
> STDOUT> [SYNC] Message sent: main
> ==> threadID = 1828
> startFrame=0; length=-1
> framesCount=13
> 0. frameID=1 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(83)
> 1. frameID=2 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 2. frameID=3 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 3. frameID=4 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 4. frameID=5 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 5. frameID=6 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 6. frameID=7 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 7. frameID=8 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 8. frameID=9 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 9. frameID=10 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 10. frameID=11 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;run(12)
> 11. frameID=12 - Lorg/apache/harmony/jpda/tests/share/Debuggee;runDebuggee(49)
> 12. frameID=13 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;main(4)
> startFrame=1; length=-1
> framesCount=12
> 1. frameID=2 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 2. frameID=3 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 3. frameID=4 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 4. frameID=5 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 5. frameID=6 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 6. frameID=7 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 7. frameID=8 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 8. frameID=9 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 9. frameID=10 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 10. frameID=11 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;run(12)
> 11. frameID=12 - Lorg/apache/harmony/jpda/tests/share/Debuggee;runDebuggee(49)
> 12. frameID=13 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;main(4)
> # ERROR: Number of recursiveMethod in frames 9 but expected 10
> [SYNC] Message sent: continue
> ==> testFrames001 FAILED 
> ----------------------------------------

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-3660) [jdktools][jpda] fix JDWP test org.apache.harmony.jpda.tests.jdwp.ThreadReference.FramesTest

Posted by "Ivan Popov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ivan Popov updated HARMONY-3660:
--------------------------------

    Patch Info: [Patch Available]

> [jdktools][jpda] fix JDWP test org.apache.harmony.jpda.tests.jdwp.ThreadReference.FramesTest
> --------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-3660
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3660
>             Project: Harmony
>          Issue Type: Bug
>          Components: JDK
>         Environment: Windows, Linux, apache-harmony-jdk-r529142
>            Reporter: Ivan Popov
>         Attachments: H3660-fix_test.patch
>
>
> The following JDWP tests
>   org.apache.harmony.jpda.tests.jdwp.ThreadReference.FramesTest
> is incorrect and should be fixed.
> The problem is that it uses 0 as an invalid value for index of a stack frame while searching for particular frame and thus may find not all frames. This leads to such diagnostics:
> ----------------------------------------
> ==> testFrames001 START 
> [SYNC] Waiting...
> STDOUT> [SYNC] Attached socket
> STDOUT> invoke tested method: depth=1
> STDOUT> invoke tested method: depth=2
> STDOUT> invoke tested method: depth=3
> STDOUT> invoke tested method: depth=4
> STDOUT> invoke tested method: depth=5
> STDOUT> invoke tested method: depth=6
> STDOUT> invoke tested method: depth=7
> STDOUT> invoke tested method: depth=8
> STDOUT> invoke tested method: depth=9
> STDOUT> sending SGNL_READY signal
> [SYNC] received message: main
> ==> testedThreadName = |main|
> STDOUT> [SYNC] Message sent: main
> ==> threadID = 1828
> startFrame=0; length=-1
> framesCount=13
> 0. frameID=1 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(83)
> 1. frameID=2 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 2. frameID=3 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 3. frameID=4 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 4. frameID=5 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 5. frameID=6 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 6. frameID=7 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 7. frameID=8 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 8. frameID=9 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 9. frameID=10 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 10. frameID=11 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;run(12)
> 11. frameID=12 - Lorg/apache/harmony/jpda/tests/share/Debuggee;runDebuggee(49)
> 12. frameID=13 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;main(4)
> startFrame=1; length=-1
> framesCount=12
> 1. frameID=2 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 2. frameID=3 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 3. frameID=4 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 4. frameID=5 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 5. frameID=6 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 6. frameID=7 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 7. frameID=8 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 8. frameID=9 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 9. frameID=10 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 10. frameID=11 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;run(12)
> 11. frameID=12 - Lorg/apache/harmony/jpda/tests/share/Debuggee;runDebuggee(49)
> 12. frameID=13 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;main(4)
> # ERROR: Number of recursiveMethod in frames 9 but expected 10
> [SYNC] Message sent: continue
> ==> testFrames001 FAILED 
> ----------------------------------------

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-3660) [jdktools][jpda] fix JDWP test org.apache.harmony.jpda.tests.jdwp.ThreadReference.FramesTest

Posted by "Ivan Popov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ivan Popov updated HARMONY-3660:
--------------------------------

    Attachment: H3660-fix_test.patch

Attached patch "H3660-fix_test.patch" fixes test to use -1 as an invalid index of a stack frame. With this patch test stably passed on both Windows and Linux.


> [jdktools][jpda] fix JDWP test org.apache.harmony.jpda.tests.jdwp.ThreadReference.FramesTest
> --------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-3660
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3660
>             Project: Harmony
>          Issue Type: Bug
>          Components: JDK
>         Environment: Windows, Linux, apache-harmony-jdk-r529142
>            Reporter: Ivan Popov
>         Attachments: H3660-fix_test.patch
>
>
> The following JDWP tests
>   org.apache.harmony.jpda.tests.jdwp.ThreadReference.FramesTest
> is incorrect and should be fixed.
> The problem is that it uses 0 as an invalid value for index of a stack frame while searching for particular frame and thus may find not all frames. This leads to such diagnostics:
> ----------------------------------------
> ==> testFrames001 START 
> [SYNC] Waiting...
> STDOUT> [SYNC] Attached socket
> STDOUT> invoke tested method: depth=1
> STDOUT> invoke tested method: depth=2
> STDOUT> invoke tested method: depth=3
> STDOUT> invoke tested method: depth=4
> STDOUT> invoke tested method: depth=5
> STDOUT> invoke tested method: depth=6
> STDOUT> invoke tested method: depth=7
> STDOUT> invoke tested method: depth=8
> STDOUT> invoke tested method: depth=9
> STDOUT> sending SGNL_READY signal
> [SYNC] received message: main
> ==> testedThreadName = |main|
> STDOUT> [SYNC] Message sent: main
> ==> threadID = 1828
> startFrame=0; length=-1
> framesCount=13
> 0. frameID=1 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(83)
> 1. frameID=2 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 2. frameID=3 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 3. frameID=4 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 4. frameID=5 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 5. frameID=6 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 6. frameID=7 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 7. frameID=8 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 8. frameID=9 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 9. frameID=10 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 10. frameID=11 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;run(12)
> 11. frameID=12 - Lorg/apache/harmony/jpda/tests/share/Debuggee;runDebuggee(49)
> 12. frameID=13 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;main(4)
> startFrame=1; length=-1
> framesCount=12
> 1. frameID=2 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 2. frameID=3 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 3. frameID=4 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 4. frameID=5 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 5. frameID=6 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 6. frameID=7 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 7. frameID=8 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 8. frameID=9 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 9. frameID=10 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 10. frameID=11 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;run(12)
> 11. frameID=12 - Lorg/apache/harmony/jpda/tests/share/Debuggee;runDebuggee(49)
> 12. frameID=13 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;main(4)
> # ERROR: Number of recursiveMethod in frames 9 but expected 10
> [SYNC] Message sent: continue
> ==> testFrames001 FAILED 
> ----------------------------------------

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (HARMONY-3660) [jdktools][jpda] fix JDWP test org.apache.harmony.jpda.tests.jdwp.ThreadReference.FramesTest

Posted by "Ivan Popov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ivan Popov closed HARMONY-3660.
-------------------------------


Thanks, Gregory. 
Verified in r529504. Closing this issue.

> [jdktools][jpda] fix JDWP test org.apache.harmony.jpda.tests.jdwp.ThreadReference.FramesTest
> --------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-3660
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3660
>             Project: Harmony
>          Issue Type: Bug
>          Components: JDK
>         Environment: Windows, Linux, apache-harmony-jdk-r529142
>            Reporter: Ivan Popov
>         Assigned To: Gregory Shimansky
>         Attachments: H3660-fix_test.patch
>
>
> The following JDWP tests
>   org.apache.harmony.jpda.tests.jdwp.ThreadReference.FramesTest
> is incorrect and should be fixed.
> The problem is that it uses 0 as an invalid value for index of a stack frame while searching for particular frame and thus may find not all frames. This leads to such diagnostics:
> ----------------------------------------
> ==> testFrames001 START 
> [SYNC] Waiting...
> STDOUT> [SYNC] Attached socket
> STDOUT> invoke tested method: depth=1
> STDOUT> invoke tested method: depth=2
> STDOUT> invoke tested method: depth=3
> STDOUT> invoke tested method: depth=4
> STDOUT> invoke tested method: depth=5
> STDOUT> invoke tested method: depth=6
> STDOUT> invoke tested method: depth=7
> STDOUT> invoke tested method: depth=8
> STDOUT> invoke tested method: depth=9
> STDOUT> sending SGNL_READY signal
> [SYNC] received message: main
> ==> testedThreadName = |main|
> STDOUT> [SYNC] Message sent: main
> ==> threadID = 1828
> startFrame=0; length=-1
> framesCount=13
> 0. frameID=1 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(83)
> 1. frameID=2 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 2. frameID=3 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 3. frameID=4 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 4. frameID=5 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 5. frameID=6 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 6. frameID=7 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 7. frameID=8 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 8. frameID=9 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 9. frameID=10 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 10. frameID=11 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;run(12)
> 11. frameID=12 - Lorg/apache/harmony/jpda/tests/share/Debuggee;runDebuggee(49)
> 12. frameID=13 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;main(4)
> startFrame=1; length=-1
> framesCount=12
> 1. frameID=2 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 2. frameID=3 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 3. frameID=4 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 4. frameID=5 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 5. frameID=6 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 6. frameID=7 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 7. frameID=8 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 8. frameID=9 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 9. frameID=10 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 10. frameID=11 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;run(12)
> 11. frameID=12 - Lorg/apache/harmony/jpda/tests/share/Debuggee;runDebuggee(49)
> 12. frameID=13 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;main(4)
> # ERROR: Number of recursiveMethod in frames 9 but expected 10
> [SYNC] Message sent: continue
> ==> testFrames001 FAILED 
> ----------------------------------------

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HARMONY-3660) [jdktools][jpda] fix JDWP test org.apache.harmony.jpda.tests.jdwp.ThreadReference.FramesTest

Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gregory Shimansky resolved HARMONY-3660.
----------------------------------------

    Resolution: Fixed

Patch is applied at 529263. Please check that the test works now.

> [jdktools][jpda] fix JDWP test org.apache.harmony.jpda.tests.jdwp.ThreadReference.FramesTest
> --------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-3660
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3660
>             Project: Harmony
>          Issue Type: Bug
>          Components: JDK
>         Environment: Windows, Linux, apache-harmony-jdk-r529142
>            Reporter: Ivan Popov
>         Assigned To: Gregory Shimansky
>         Attachments: H3660-fix_test.patch
>
>
> The following JDWP tests
>   org.apache.harmony.jpda.tests.jdwp.ThreadReference.FramesTest
> is incorrect and should be fixed.
> The problem is that it uses 0 as an invalid value for index of a stack frame while searching for particular frame and thus may find not all frames. This leads to such diagnostics:
> ----------------------------------------
> ==> testFrames001 START 
> [SYNC] Waiting...
> STDOUT> [SYNC] Attached socket
> STDOUT> invoke tested method: depth=1
> STDOUT> invoke tested method: depth=2
> STDOUT> invoke tested method: depth=3
> STDOUT> invoke tested method: depth=4
> STDOUT> invoke tested method: depth=5
> STDOUT> invoke tested method: depth=6
> STDOUT> invoke tested method: depth=7
> STDOUT> invoke tested method: depth=8
> STDOUT> invoke tested method: depth=9
> STDOUT> sending SGNL_READY signal
> [SYNC] received message: main
> ==> testedThreadName = |main|
> STDOUT> [SYNC] Message sent: main
> ==> threadID = 1828
> startFrame=0; length=-1
> framesCount=13
> 0. frameID=1 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(83)
> 1. frameID=2 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 2. frameID=3 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 3. frameID=4 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 4. frameID=5 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 5. frameID=6 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 6. frameID=7 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 7. frameID=8 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 8. frameID=9 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 9. frameID=10 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 10. frameID=11 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;run(12)
> 11. frameID=12 - Lorg/apache/harmony/jpda/tests/share/Debuggee;runDebuggee(49)
> 12. frameID=13 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;main(4)
> startFrame=1; length=-1
> framesCount=12
> 1. frameID=2 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 2. frameID=3 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 3. frameID=4 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 4. frameID=5 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 5. frameID=6 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 6. frameID=7 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 7. frameID=8 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 8. frameID=9 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 9. frameID=10 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;recursiveMethod(48)
> 10. frameID=11 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;run(12)
> 11. frameID=12 - Lorg/apache/harmony/jpda/tests/share/Debuggee;runDebuggee(49)
> 12. frameID=13 - Lorg/apache/harmony/jpda/tests/jdwp/ThreadReference/FramesDebuggee;main(4)
> # ERROR: Number of recursiveMethod in frames 9 but expected 10
> [SYNC] Message sent: continue
> ==> testFrames001 FAILED 
> ----------------------------------------

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.