You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2022/10/09 15:22:10 UTC
[GitHub] [shenyu] yunlongn opened a new pull request, #4060: [type:feat] Modify shenyu sdk and add shenyu.instance.clientEnable
yunlongn opened a new pull request, #4060:
URL: https://github.com/apache/shenyu/pull/4060
<!-- Describe your PR here; eg. Fixes #issueNo -->
`shenyu.instance.enabled` is true to register itself as a gateway to the center
So add `shenyu.instance.clientEnable` for shenyu-sdk
<!--
Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
-->
Make sure that:
- [x] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
- [x] You submit test cases (unit or integration tests) that back your changes.
- [x] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] codecov-commenter commented on pull request #4060: [type:feat] Modify shenyu sdk and add shenyu.instance.clientEnable
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #4060:
URL: https://github.com/apache/shenyu/pull/4060#issuecomment-1272568717
# [Codecov](https://codecov.io/gh/apache/shenyu/pull/4060?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#4060](https://codecov.io/gh/apache/shenyu/pull/4060?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bdc09c2) into [master](https://codecov.io/gh/apache/shenyu/commit/c986aad3a31f051a374f0d60adac643d3ec36c55?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c986aad) will **decrease** coverage by `0.31%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #4060 +/- ##
============================================
- Coverage 70.01% 69.69% -0.32%
+ Complexity 6749 6710 -39
============================================
Files 935 935
Lines 25443 25438 -5
Branches 2290 2287 -3
============================================
- Hits 17814 17730 -84
- Misses 6232 6307 +75
- Partials 1397 1401 +4
```
| [Impacted Files](https://codecov.io/gh/apache/shenyu/pull/4060?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../org/apache/shenyu/common/config/ShenyuConfig.java](https://codecov.io/gh/apache/shenyu/pull/4060/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi9jb25maWcvU2hlbnl1Q29uZmlnLmphdmE=) | `72.56% <0.00%> (-0.67%)` | :arrow_down: |
| [...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java](https://codecov.io/gh/apache/shenyu/pull/4060/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9jYWNoZS9HcnBjQ2xpZW50Q2FjaGUuamF2YQ==) | `68.75% <0.00%> (-31.25%)` | :arrow_down: |
| [.../client/server/consul/ShenyuConsulConfigWatch.java](https://codecov.io/gh/apache/shenyu/pull/4060/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXJlZ2lzdGVyLWNlbnRlci9zaGVueXUtcmVnaXN0ZXItY2xpZW50LXNlcnZlci9zaGVueXUtcmVnaXN0ZXItY2xpZW50LXNlcnZlci1jb25zdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9yZWdpc3Rlci9jbGllbnQvc2VydmVyL2NvbnN1bC9TaGVueXVDb25zdWxDb25maWdXYXRjaC5qYXZh) | `60.41% <0.00%> (-25.00%)` | :arrow_down: |
| [...controller/ShenyuClientHttpRegistryController.java](https://codecov.io/gh/apache/shenyu/pull/4060/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9TaGVueXVDbGllbnRIdHRwUmVnaXN0cnlDb250cm9sbGVyLmphdmE=) | `77.77% <0.00%> (-22.23%)` | :arrow_down: |
| [...yu/sync/data/http/refresh/AbstractDataRefresh.java](https://codecov.io/gh/apache/shenyu/pull/4060/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvcmVmcmVzaC9BYnN0cmFjdERhdGFSZWZyZXNoLmphdmE=) | `68.96% <0.00%> (-13.80%)` | :arrow_down: |
| [...ruptor/RegisterClientServerDisruptorPublisher.java](https://codecov.io/gh/apache/shenyu/pull/4060/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vZGlzcnVwdG9yL1JlZ2lzdGVyQ2xpZW50U2VydmVyRGlzcnVwdG9yUHVibGlzaGVyLmphdmE=) | `52.94% <0.00%> (-11.77%)` | :arrow_down: |
| [...a/org/apache/shenyu/common/utils/VersionUtils.java](https://codecov.io/gh/apache/shenyu/pull/4060/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi91dGlscy9WZXJzaW9uVXRpbHMuamF2YQ==) | `67.85% <0.00%> (-10.72%)` | :arrow_down: |
| [...henyu/plugin/grpc/resolver/ShenyuNameResolver.java](https://codecov.io/gh/apache/shenyu/pull/4060/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9yZXNvbHZlci9TaGVueXVOYW1lUmVzb2x2ZXIuamF2YQ==) | `54.25% <0.00%> (-9.58%)` | :arrow_down: |
| [...che/shenyu/sync/data/http/HttpSyncDataService.java](https://codecov.io/gh/apache/shenyu/pull/4060/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvSHR0cFN5bmNEYXRhU2VydmljZS5qYXZh) | `81.63% <0.00%> (-8.17%)` | :arrow_down: |
| [.../apache/shenyu/admin/model/dto/BatchCommonDTO.java](https://codecov.io/gh/apache/shenyu/pull/4060/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vbW9kZWwvZHRvL0JhdGNoQ29tbW9uRFRPLmphdmE=) | `50.00% <0.00%> (-7.15%)` | :arrow_down: |
| ... and [36 more](https://codecov.io/gh/apache/shenyu/pull/4060/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] yu199195 merged pull request #4060: [type:feat] Modify shenyu sdk and add shenyu.sdk.enable
Posted by GitBox <gi...@apache.org>.
yu199195 merged PR #4060:
URL: https://github.com/apache/shenyu/pull/4060
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] yunlongn commented on a diff in pull request #4060: [type:feat] Modify shenyu sdk and add shenyu.instance.clientEnable
Posted by GitBox <gi...@apache.org>.
yunlongn commented on code in PR #4060:
URL: https://github.com/apache/shenyu/pull/4060#discussion_r990959383
##########
shenyu-spring-boot-starter/shenyu-spring-boot-starter-instance/src/main/java/org/apache/shenyu/springboot/starter/instance/ShenyuInstanceConfiguration.java:
##########
@@ -39,4 +41,19 @@ public class ShenyuInstanceConfiguration {
public InstanceRegisterListener instanceRegisterListener(final ShenyuConfig config) {
return new InstanceRegisterListener(config.getInstance());
}
+
+ /**
+ * ShenYu Instance Register Repository.
+ * expose to shenYu-sdk.
+ *
+ * @param config the config
+ * @return ShenYu Instance Register Repository
+ */
+ @Bean
+ @ConditionalOnProperty(name = "shenyu.instance.clientEnable", havingValue = "true")
Review Comment:
I get it, I'll revise it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] yunlongn commented on a diff in pull request #4060: [type:feat] Modify shenyu sdk and add shenyu.instance.clientEnable
Posted by GitBox <gi...@apache.org>.
yunlongn commented on code in PR #4060:
URL: https://github.com/apache/shenyu/pull/4060#discussion_r990949519
##########
shenyu-spring-boot-starter/shenyu-spring-boot-starter-instance/src/main/java/org/apache/shenyu/springboot/starter/instance/ShenyuInstanceConfiguration.java:
##########
@@ -39,4 +41,19 @@ public class ShenyuInstanceConfiguration {
public InstanceRegisterListener instanceRegisterListener(final ShenyuConfig config) {
return new InstanceRegisterListener(config.getInstance());
}
+
+ /**
+ * ShenYu Instance Register Repository.
+ * expose to shenYu-sdk.
+ *
+ * @param config the config
+ * @return ShenYu Instance Register Repository
+ */
+ @Bean
+ @ConditionalOnProperty(name = "shenyu.instance.clientEnable", havingValue = "true")
Review Comment:
InstanceRegisterListener will register the service to the registry, shenyu-sdk does not need this operation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] yu199195 commented on a diff in pull request #4060: [type:feat] Modify shenyu sdk and add shenyu.instance.clientEnable
Posted by GitBox <gi...@apache.org>.
yu199195 commented on code in PR #4060:
URL: https://github.com/apache/shenyu/pull/4060#discussion_r990955426
##########
shenyu-spring-boot-starter/shenyu-spring-boot-starter-instance/src/main/java/org/apache/shenyu/springboot/starter/instance/ShenyuInstanceConfiguration.java:
##########
@@ -39,4 +41,19 @@ public class ShenyuInstanceConfiguration {
public InstanceRegisterListener instanceRegisterListener(final ShenyuConfig config) {
return new InstanceRegisterListener(config.getInstance());
}
+
+ /**
+ * ShenYu Instance Register Repository.
+ * expose to shenYu-sdk.
+ *
+ * @param config the config
+ * @return ShenYu Instance Register Repository
+ */
+ @Bean
+ @ConditionalOnProperty(name = "shenyu.instance.clientEnable", havingValue = "true")
Review Comment:
Yes， so this code maybe in spring-boot-starter-sdk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] yu199195 commented on a diff in pull request #4060: [type:feat] Modify shenyu sdk and add shenyu.instance.clientEnable
Posted by GitBox <gi...@apache.org>.
yu199195 commented on code in PR #4060:
URL: https://github.com/apache/shenyu/pull/4060#discussion_r990886887
##########
shenyu-spring-boot-starter/shenyu-spring-boot-starter-instance/src/main/java/org/apache/shenyu/springboot/starter/instance/ShenyuInstanceConfiguration.java:
##########
@@ -39,4 +41,19 @@ public class ShenyuInstanceConfiguration {
public InstanceRegisterListener instanceRegisterListener(final ShenyuConfig config) {
return new InstanceRegisterListener(config.getInstance());
}
+
+ /**
+ * ShenYu Instance Register Repository.
+ * expose to shenYu-sdk.
+ *
+ * @param config the config
+ * @return ShenYu Instance Register Repository
+ */
+ @Bean
+ @ConditionalOnProperty(name = "shenyu.instance.clientEnable", havingValue = "true")
Review Comment:
whats mean？
ShenyuInstanceRegisterRepository already init in InstanceRegisterListener
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org