You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/06/16 01:22:29 UTC
[GitHub] [hbase] joshelser opened a new pull request #1908: HBASE-19365 Guard against a missing table descriptor which crashes ma…
joshelser opened a new pull request #1908:
URL: https://github.com/apache/hbase/pull/1908
…ster
While we never expect table descriptors to be missing, a corrupt meta
(rogue merge daughters) or corrupt filesystem (missing tabledesc) can result in the master crashing before regions get assigned. We can guard against that happening with a simple null-check.
I didn't try to reproduce this in a unit test, but I was able to reproduce it in a local environment doing the following:
* `create 'usertable', 'family', {SPLITS => (1..n_splits).map{|i| "user#{i}"}}`
* `(0..n_splits).map{|i| put 'usertable', "user#{i}", 'family:q', "#{i}"}`
* Choose two regions in the table and use `merge_region` to merge them together (required!)
* Kill everything (master and regionserver)
* `hdfs dfs -mv /hbase/data/default/usertable/.tabledesc /sidelined-tabledesc`
* Restart HBase
* Observe master crash
After this fix, the master stays up (and hbck can be used normally to generate a new tabledesc and reassign any regions stuck unassigned)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani closed pull request #1908: HBASE-19365 Guard against a missing table descriptor which crashes ma…
Posted by GitBox <gi...@apache.org>.
virajjasani closed pull request #1908:
URL: https://github.com/apache/hbase/pull/1908
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] joshelser commented on pull request #1908: HBASE-19365 Guard against a missing table descriptor which crashes ma…
Posted by GitBox <gi...@apache.org>.
joshelser commented on pull request #1908:
URL: https://github.com/apache/hbase/pull/1908#issuecomment-646136031
Oh, duh. This didn't go to `master` so my `Closes..` wouldn't work. Thanks Viraj!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on pull request #1908: HBASE-19365 Guard against a missing table descriptor which crashes ma…
Posted by GitBox <gi...@apache.org>.
virajjasani commented on pull request #1908:
URL: https://github.com/apache/hbase/pull/1908#issuecomment-646135291
Closing the PR @joshelser :)
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1908: HBASE-19365 Guard against a missing table descriptor which crashes ma…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1908:
URL: https://github.com/apache/hbase/pull/1908#issuecomment-644523422
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 7m 44s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ branch-1 Compile Tests _ |
| +1 :green_heart: | mvninstall | 10m 33s | branch-1 passed |
| +1 :green_heart: | compile | 0m 44s | branch-1 passed with JDK v1.8.0_252 |
| +1 :green_heart: | compile | 0m 47s | branch-1 passed with JDK v1.7.0_262 |
| +1 :green_heart: | checkstyle | 2m 2s | branch-1 passed |
| +1 :green_heart: | shadedjars | 3m 17s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 52s | branch-1 passed with JDK v1.8.0_252 |
| +1 :green_heart: | javadoc | 0m 40s | branch-1 passed with JDK v1.7.0_262 |
| +0 :ok: | spotbugs | 3m 10s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 3m 7s | branch-1 passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 2m 5s | the patch passed |
| +1 :green_heart: | compile | 0m 43s | the patch passed with JDK v1.8.0_252 |
| +1 :green_heart: | javac | 0m 43s | the patch passed |
| +1 :green_heart: | compile | 0m 52s | the patch passed with JDK v1.7.0_262 |
| +1 :green_heart: | javac | 0m 52s | the patch passed |
| +1 :green_heart: | checkstyle | 1m 53s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 3m 9s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 5m 5s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | javadoc | 0m 35s | the patch passed with JDK v1.8.0_252 |
| +1 :green_heart: | javadoc | 0m 43s | the patch passed with JDK v1.7.0_262 |
| +1 :green_heart: | findbugs | 3m 0s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 128m 43s | hbase-server in the patch passed. |
| +1 :green_heart: | asflicense | 0m 40s | The patch does not generate ASF License warnings. |
| | | 181m 6s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1908/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1908 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux ccfe85a5fa7f 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1908/out/precommit/personality/provided.sh |
| git revision | branch-1 / 5d64f06 |
| Default Java | 1.7.0_262 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_252 /usr/lib/jvm/zulu-7-amd64:1.7.0_262 |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1908/1/testReport/ |
| Max. process+thread count | 4401 (vs. ulimit of 10000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1908/1/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org