You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "mingchao zhao (Jira)" <ji...@apache.org> on 2020/07/31 08:22:00 UTC
[jira] [Created] (HDDS-4054) Remove duplicate judgments in
allocateBlockInKey
mingchao zhao created HDDS-4054:
-----------------------------------
Summary: Remove duplicate judgments in allocateBlockInKey
Key: HDDS-4054
URL: https://issues.apache.org/jira/browse/HDDS-4054
Project: Hadoop Distributed Data Store
Issue Type: Bug
Reporter: mingchao zhao
In HDDS-1666 we have [changed the size of the key size|https://github.com/apache/hadoop-ozone/blob/a95b0b8580ae2b3d093505efd85eeb31117467e2/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java#L438]. So this size must be >0.
{code:java}
//代码占位符
final long size = args.getDataSize() > 0 ?
args.getDataSize() : scmBlockSize;
{code}
We pass this size when you call allocateBlockInKey. The key must be greater than 0, so the "if (size > 0){}" in allocateBlockInKey is redundant and should be removed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org