You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/09/08 12:14:30 UTC
[GitHub] [superset] michael-s-molina opened a new pull request, #21376: test: Fixes act errors in HeaderReportDropdown test
michael-s-molina opened a new pull request, #21376:
URL: https://github.com/apache/superset/pull/21376
### SUMMARY
This PR fixes 5 act errors in `superset-frontend/src/components/ReportModal/HeaderReportDropdown/index.test.tsx`
### TESTING INSTRUCTIONS
- Execute the component tests
- Observe that there are no act errors in the console
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina merged pull request #21376: test: Fixes act errors in HeaderReportDropdown test
Posted by GitBox <gi...@apache.org>.
michael-s-molina merged PR #21376:
URL: https://github.com/apache/superset/pull/21376
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #21376: test: Fixes act errors in HeaderReportDropdown test
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #21376:
URL: https://github.com/apache/superset/pull/21376#issuecomment-1240834485
# [Codecov](https://codecov.io/gh/apache/superset/pull/21376?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21376](https://codecov.io/gh/apache/superset/pull/21376?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f76a3f0) into [master](https://codecov.io/gh/apache/superset/commit/0601b2db995781b3d67ca4259c9feea6cdc86635?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0601b2d) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #21376 +/- ##
=======================================
Coverage 66.61% 66.61%
=======================================
Files 1791 1791
Lines 68538 68559 +21
Branches 7310 7319 +9
=======================================
+ Hits 45655 45671 +16
Misses 21002 21002
- Partials 1881 1886 +5
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `52.80% <ø> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/21376?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ard/components/DrillDetailPane/DrillDetailPane.tsx](https://codecov.io/gh/apache/superset/pull/21376/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0RyaWxsRGV0YWlsUGFuZS9EcmlsbERldGFpbFBhbmUudHN4) | `81.01% <0.00%> (-1.75%)` | :arrow_down: |
| [...rset-frontend/src/components/MetadataBar/index.tsx](https://codecov.io/gh/apache/superset/pull/21376/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWV0YWRhdGFCYXIvaW5kZXgudHN4) | | |
| [...rontend/src/components/MetadataBar/MetadataBar.tsx](https://codecov.io/gh/apache/superset/pull/21376/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWV0YWRhdGFCYXIvTWV0YWRhdGFCYXIudHN4) | `96.00% <0.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org