You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/22 02:13:29 UTC

[GitHub] [doris] jackwener commented on pull request #11073: [enhance](nereids): use optional for combine()

jackwener commented on PR #11073:
URL: https://github.com/apache/doris/pull/11073#issuecomment-1192107867

   I don't think so, because this function is for combine expression by use `And` or `Or`.
   Empty List is an abnormal input, it's invalid by using `LiteralTrue` as result.
   And `LiteralTrue` defeat the intent of this function. We want to combine but return a `LiteralTrue`, it's strange.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org