[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #4387: Adding Calcite SQL Parser and make another entry point to query Pinot

[GitBox <gi...@apache.org>]

mayankshriv commented on a change in pull request #4387: Adding Calcite SQL Parser and make another entry point to query Pinot
URL: https://github.com/apache/incubator-pinot/pull/4387#discussion_r300514894
 
 

 ##########
 File path: pinot-api/src/main/java/org/apache/pinot/client/JsonAsyncHttpPinotClientTransport.java
 ##########
 @@ -61,9 +61,13 @@ public BrokerResponse executeQuery(String brokerAddress, String query)
 
   @Override
   public Future<BrokerResponse> executeQueryAsync(String brokerAddress, final String query) {
+    return executeQueryAsync(brokerAddress, new Request("pql", query));
+  }
+
+  public Future<BrokerResponse> executePinotQueryAsync(String brokerAddress, final Request r) {
 
 Review comment:
   Nit: s/r/request.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org