[jira] [Commented] (AIRFLOW-5322) Fix flaky gcp transfer hook test

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-5322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16917073#comment-16917073 ] 

ASF GitHub Bot commented on AIRFLOW-5322:
-----------------------------------------

nuclearpinguin commented on pull request #5931: [AIRFLOW-5322] Fix flaky gcp transfer hook test
URL: https://github.com/apache/airflow/pull/5931
 
 
   This commit fixes flaky test (occured in python 3.5). I am not yet sure what was the
   reason but I simplified the mocking and everything seems to be ok. The error seems to be introduced in this PR https://github.com/apache/airflow/pull/5912
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-5322
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
   This commit fixes flaky test (occured in python 3.5). I am not yet sure what was the
   reason but I simplified the mocking and everything seems to be ok. The error seems to be introduced in this PR https://github.com/apache/airflow/pull/5912
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
   ### Code Quality
   
   - [ ] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Fix flaky gcp transfer hook test
> --------------------------------
>
>                 Key: AIRFLOW-5322
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5322
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: gcp, tests
>    Affects Versions: 1.10.4
>            Reporter: Tomasz Urbaszek
>            Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.2#803003)