[GitHub] [zookeeper] ztzg commented on issue #1169: ZOOKEEPER-3641: New ZOO_VERSION define breaks Perl & Python contribs

[GitBox <gi...@apache.org>]

ztzg commented on issue #1169: ZOOKEEPER-3641: New ZOO_VERSION define breaks Perl & Python contribs
URL: https://github.com/apache/zookeeper/pull/1169#issuecomment-563266706
 
 
   Hi @eolivelli,
   
   (Github tells me you "requested changes," but I cannot find review notes.  Is it only about the questions below, or am I missing something?)
   
   > My bad! I did not check the contrib modules!
   
   Right; this is bound to happen if they are not part of the release checklist.
   
   > Let's commit this fix and fix master branch.
   
   Okay :)
    
   > Is there any way to create a script (or use Maven) to build these modules in Travis?
   
   I suppose this is the "change" you are requesting?  I can have a look, but should such a thing not be done as another PR/ticket?  (I'm not familiar with the plumbing of the Apache/Maven CI, and have no idea of how many iterations it will require.)
   
   > It would be good to move this 'official' clients to the zookeeper-clients module and move them out of 'contrib'
   > I thought they were quite unused but id there is interested we should bring them to the front row together with the C client
   
   I am aware of some users of the "official" Perl client.  I don't know any users of the "official" Python client; most seem to be using [Kazoo](https://github.com/python-zk/kazoo) instead.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services