You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by lc...@apache.org on 2022/09/28 05:29:52 UTC

[beam] branch master updated: Pin objsize version to avoid regression in 0.6.0 (#23396)

This is an automated email from the ASF dual-hosted git repository.

lcwik pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git


The following commit(s) were added to refs/heads/master by this push:
     new 91d79d973a3 Pin objsize version to avoid regression in 0.6.0 (#23396)
91d79d973a3 is described below

commit 91d79d973a327b6d22314c8e28bf1b93bc608c2b
Author: Luke Cwik <lc...@google.com>
AuthorDate: Tue Sep 27 22:29:44 2022 -0700

    Pin objsize version to avoid regression in 0.6.0 (#23396)
    
    * Pin objsize version to avoid regression in 0.6.0
    
    tox -c tox.ini -e py37 -- apache_beam/transforms/stats_test.py::ApproximateUniqueTest_0
    
    fails with:
    
    objsize.py
        exclude_set.update(id(vars(m)) for m in list(sys.modules.values()))
    _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
    
    .0 = <list_iterator object at 0x7fbe55e89410>
    
    >   exclude_set.update(id(vars(m)) for m in list(sys.modules.values()))
    E   TypeError: vars() argument must have __dict__ attribute [while running 'Globally/CombineGlobally(ApproximateQuantilesCombineFn)/InjectDefault']
    
    Fixes #23395
    
    * Add an upper bound to objsize.
    
    Co-authored-by: tvalentyn <tv...@users.noreply.github.com>
---
 sdks/python/setup.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sdks/python/setup.py b/sdks/python/setup.py
index 8017c1b692a..35750f34491 100644
--- a/sdks/python/setup.py
+++ b/sdks/python/setup.py
@@ -227,7 +227,8 @@ if __name__ == '__main__':
         'hdfs>=2.1.0,<3.0.0',
         'httplib2>=0.8,<0.21.0',
         'numpy>=1.14.3,<1.23.0',
-        'objsize>=0.5.2,<1',
+        # Tight bound since minor version releases caused breakages.
+        'objsize>=0.5.2,<0.6.0',
         'pymongo>=3.8.0,<4.0.0',
         'protobuf>=3.12.2,<4',
         'proto-plus>=1.7.1,<2',