You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by srowen <gi...@git.apache.org> on 2018/12/02 15:23:54 UTC

[GitHub] spark pull request #22683: [SPARK-25696] The storage memory displayed on spa...

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22683#discussion_r238102080
  
    --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
    @@ -1164,17 +1164,17 @@ private[spark] object Utils extends Logging {
         } else {
           val (value, unit) = {
             if (size >= 2 * EB) {
    -          (BigDecimal(size) / EB, "EB")
    +          (BigDecimal(size) / EB, "EiB")
    --- End diff --
    
    For full consistency, how about modifying the values like EB and PB above? 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org