You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/22 08:51:24 UTC

[GitHub] [doris] FreeOnePlus opened a new pull request, #10339: [typo](docs) Update compile Dockerfile in developer

FreeOnePlus opened a new pull request, #10339:
URL: https://github.com/apache/doris/pull/10339

   Adjust the default JDK version of the Docker build image from JDK-11 to JDK-1.8.0
   # Proposed changes
   
   Issue Number: close #xxx
   
   ## Problem Summary:
   
   Describe the overview of changes.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: (Yes/No/I Don't know)
   2. Has unit tests been added: (Yes/No/No Need)
   3. Has document been added or modified: (Yes/No/No Need)
   4. Does it need to update dependencies: (Yes/No)
   5. Are there any changes that cannot be rolled back: (Yes/No)
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on pull request #10339: [typo](docs) Update compile Dockerfile in developer

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10339:
URL: https://github.com/apache/doris/pull/10339#issuecomment-1197510256

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] yiguolei merged pull request #10339: [typo](docs) Update compile Dockerfile in developer

Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #10339:
URL: https://github.com/apache/doris/pull/10339


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] FreeOnePlus commented on pull request #10339: [typo](docs) Update compile Dockerfile in developer

Posted by GitBox <gi...@apache.org>.
FreeOnePlus commented on PR #10339:
URL: https://github.com/apache/doris/pull/10339#issuecomment-1163800037

   > Why downgrade the version of JDK?
   
   In the past practice process, I found that whether it is a developer or a community user, the JDK version is still mostly 1.8.0. In our Docker compiled image, the default JDK-11 version is adopted. Not paying attention to the JDK version problem often leads to taking time to compile, but getting a binary file with an incorrect JDK version, so I want to change the default JDK version of Doris's Docker compiled image to JDK-1.8.0.
   
   At the same time, I also sent a discussion email to the dev mailing group, welcome to reply to the discussion, thk~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] adonis0147 commented on pull request #10339: [typo](docs) Update compile Dockerfile in developer

Posted by GitBox <gi...@apache.org>.
adonis0147 commented on PR #10339:
URL: https://github.com/apache/doris/pull/10339#issuecomment-1162869106

   Why downgrade the version of JDK?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] yiguolei commented on pull request #10339: [typo](docs) Update compile Dockerfile in developer

Posted by GitBox <gi...@apache.org>.
yiguolei commented on PR #10339:
URL: https://github.com/apache/doris/pull/10339#issuecomment-1197509427

   As we disscussed in email and wechat, doris will support jdk 8 as default jdk so I will merge it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on pull request #10339: [typo](docs) Update compile Dockerfile in developer

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10339:
URL: https://github.com/apache/doris/pull/10339#issuecomment-1197510285

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org