You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/08/25 23:08:49 UTC
[GitHub] [beam] nehsyc commented on a change in pull request #12678: [BEAM-10703] Add a step property for shardable states during Dataflow graph translation (Java)
nehsyc commented on a change in pull request #12678:
URL: https://github.com/apache/beam/pull/12678#discussion_r476835000
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/GroupIntoBatches.java
##########
@@ -100,8 +99,7 @@ public long getBatchSize() {
ParDo.of(new GroupIntoBatchesDoFn<>(batchSize, allowedLateness, keyCoder, valueCoder)));
}
- @VisibleForTesting
- static class GroupIntoBatchesDoFn<K, InputT>
+ public static class GroupIntoBatchesDoFn<K, InputT>
Review comment:
Yeah I did try matching the transform by `transform instanceof GroupIntoBatches` but got error:
```
Inconvertible types; cannot cast 'org.apache.beam.runners.dataflow.PrimitiveParDoSingleFactory.ParDoSingle<InputT,OutputT>' to 'org.apache.beam.sdk.transforms.GroupIntoBatches'
```
Any ideas?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org