[GitHub] [spark] pan3793 commented on a diff in pull request #37386: [SPARK-39958][SQL] Add warning log when unable to load custom metric object

[GitBox <gi...@apache.org>]

pan3793 commented on code in PR #37386:
URL: https://github.com/apache/spark/pull/37386#discussion_r936208670


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListener.scala:
##########
@@ -220,7 +220,10 @@ class SQLAppStatusListener(
             metricAggregationMap.put(className, method)
             method
           } catch {
-            case NonFatal(_) =>
+            case NonFatal(e) =>
+              logWarning(s"Unable to load custom metric object for class `$className`. " +
+                "Please make sure that the custom metric class is in the classpath and " +
+                "it has 0-arg constructor.", e)

Review Comment:
   `Utils#loadExtensions` also allows "single-argument constructor that accepts SparkConf", do we need to mention that?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org