You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/03/26 19:12:08 UTC

[GitHub] [geode] Bill commented on a change in pull request #6184: GEODE-8963: update client/server on-wire version for 1.14.0

Bill commented on a change in pull request #6184:
URL: https://github.com/apache/geode/pull/6184#discussion_r602531908



##########
File path: geode-serialization/src/main/java/org/apache/geode/internal/serialization/KnownVersion.java
##########
@@ -249,7 +249,7 @@
   @Immutable
   public static final KnownVersion GEODE_1_14_0 =
       new KnownVersion("GEODE", "1.14.0", (byte) 1, (byte) 14, (byte) 0, (byte) 0,
-          GEODE_1_14_0_ORDINAL, true);
+          GEODE_1_14_0_ORDINAL);

Review comment:
       On the `support/1.14` branch the `GEODE_1_14_0` `KnownVersion` is constructed with `modifiesClientServerProtocol` set to `true`. Why does this PR change it back to `false`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org