You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by "William A. Rowe, Jr." <wr...@rowe-clan.net> on 2008/06/17 15:40:06 UTC
[vote] Release apr[-util] 1.3.2
Candidates will be up at http://apr.apache.org/dev/dist/ once the sync
happens within the hour... vote away;
+/-1
[ ] Release apr 1.3.2 as GA
[ ] Release apr-util 1.3.2 as GA
Of course 1.3.1 images were scuttled, thanks to all who tested! Windows
.zip's will follow after a bit of initial response for unix.
Re: [vote] Release apr[-util] 1.3.2
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Lucian Adrian Grijincu wrote:
>
> Afterwards I ran ./buildconf to see whether some things run haywire
> because of it. The only thing noteworthy was apr-util's ./buildconf
> warning. All tests ran ok.
You mean the nested expat's ./buildconf warning ;-)
Re: [vote] Release apr[-util] 1.3.2
Posted by Lucian Adrian Grijincu <lu...@gmail.com>.
On Tue, Jun 17, 2008 at 18:44, Paul Querna <ch...@force-elite.com> wrote:
> On a release tarball, you shouldn't have to run buildconf, infact I'd say
> its better not too -- we want to make sure the packagers generated
> ./configure works correctly.
I know this policy.
I first tested both apr and apr-util with the tar ball provided
./configure. There were no incidents.
Afterwards I ran ./buildconf to see whether some things run haywire
because of it. The only thing noteworthy was apr-util's ./buildconf
warning. All tests ran ok.
--
Lucian
Re: [vote] Release apr[-util] 1.3.2
Posted by Paul Querna <ch...@force-elite.com>.
Lucian Adrian Grijincu wrote:
> On Tue, Jun 17, 2008 at 16:40, William A. Rowe, Jr. <wr...@rowe-clan.net> wrote:
>> Candidates will be up at http://apr.apache.org/dev/dist/ once the sync
>> happens within the hour... vote away;
>>
>
> Ubuntu x86 2.6.24-19-generic
>> [+1] Release apr 1.3.2 as GA
>> [+1] Release apr-util 1.3.2 as GA
>
> The only thing that stands out is apr-util's ./buildconf:
> autoheader: WARNING: Using auxiliary files such as `acconfig.h', `config.h.bot'
> autoheader: WARNING: and `config.h.top', to define templates for `config.h.in'
> autoheader: WARNING: is deprecated and discouraged.
> autoheader:
> autoheader: WARNING: Using the third argument of `AC_DEFINE' and
> autoheader: WARNING: `AC_DEFINE_UNQUOTED' allows one to define a
> template without
> autoheader: WARNING: `acconfig.h':
> autoheader:
> autoheader: WARNING: AC_DEFINE([NEED_FUNC_MAIN], 1,
> autoheader: [Define if a function `main' is needed.])
> autoheader:
> autoheader: WARNING: More sophisticated templates can also be produced, see the
> autoheader: WARNING: documentation.
>
> but this is a non-issue :)
>
On a release tarball, you shouldn't have to run buildconf, infact I'd
say its better not too -- we want to make sure the packagers generated
./configure works correctly.
-Paul
Re: [vote] Release apr[-util] 1.3.2
Posted by Lucian Adrian Grijincu <lu...@gmail.com>.
On Tue, Jun 17, 2008 at 16:40, William A. Rowe, Jr. <wr...@rowe-clan.net> wrote:
> Candidates will be up at http://apr.apache.org/dev/dist/ once the sync
> happens within the hour... vote away;
>
Ubuntu x86 2.6.24-19-generic
> [+1] Release apr 1.3.2 as GA
> [+1] Release apr-util 1.3.2 as GA
The only thing that stands out is apr-util's ./buildconf:
autoheader: WARNING: Using auxiliary files such as `acconfig.h', `config.h.bot'
autoheader: WARNING: and `config.h.top', to define templates for `config.h.in'
autoheader: WARNING: is deprecated and discouraged.
autoheader:
autoheader: WARNING: Using the third argument of `AC_DEFINE' and
autoheader: WARNING: `AC_DEFINE_UNQUOTED' allows one to define a
template without
autoheader: WARNING: `acconfig.h':
autoheader:
autoheader: WARNING: AC_DEFINE([NEED_FUNC_MAIN], 1,
autoheader: [Define if a function `main' is needed.])
autoheader:
autoheader: WARNING: More sophisticated templates can also be produced, see the
autoheader: WARNING: documentation.
but this is a non-issue :)
--
Lucian
Re: [vote] Release apr[-util] 1.3.2
Posted by Bojan Smojver <bo...@rexursive.com>.
On Tue, 2008-06-17 at 21:50 -0500, William A. Rowe, Jr. wrote:
> Typical of IPV6 without a configured IPV6 interface, please confirm.
Correct, no IPV6 on the box.
--
Bojan
Re: [vote] Release apr[-util] 1.3.2
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Bojan Smojver wrote:
> Also, HP-UX 11.11, PA-RISC, in 32-bit mode, APR, compiled with GCC:
> testsockets 7 3 42.86%
> testsockets : |Line 70: expected <0>, but saw <221>
> |Line 85: expected <0>, but saw <221>
> |Line 112: expected <0>, but saw <221>
> \Line 185: Condition is false, but expected true
Typical of IPV6 without a configured IPV6 interface, please confirm.
Re: [vote] Release apr[-util] 1.3.2
Posted by Bojan Smojver <bo...@rexursive.com>.
Also, HP-UX 11.11, PA-RISC, in 32-bit mode, APR, compiled with GCC:
Failed Tests Total Fail Failed %
===================================================
testatomic 19 1 5.26%
testprocmutex 4 1 25.00%
testsockets 7 3 42.86%
Or more detailed:
----------------
testatomic : -Line 280: Failed creating threads
testprocmutex : -Line 107: child did not terminate with success
testsockets : |Line 70: expected <0>, but saw <221>
|Line 85: expected <0>, but saw <221>
|Line 112: expected <0>, but saw <221>
\Line 185: Condition is false, but expected true
----------------
Not sure if these are regressions or not. Just wanted to make sure
people are aware.
APU, all tests passed on this platform.
This is just FYI.
--
Bojan
Re: [vote] Release apr[-util] 1.3.2
Posted by Bojan Smojver <bo...@rexursive.com>.
On Tue, 2008-06-17 at 08:40 -0500, William A. Rowe, Jr. wrote:
> +/-1
> [+1] Release apr 1.3.2 as GA
> [+1] Release apr-util 1.3.2 as GA
Good MD5s. Good signatures.
Fedora 9, i686/x86_64.
CentOS 5, i686/x86_64.
RHEL 4, i686.
CentOS 3, i686.
--
Bojan
Re: [vote] Release apr[-util] 1.3.2
Posted by Ruediger Pluem <rp...@apache.org>.
On 06/17/2008 11:57 PM, Lucian Adrian Grijincu wrote:
> On Wed, Jun 18, 2008 at 00:53, Ruediger Pluem <rp...@apache.org> wrote:
>> Please execute the following command on your box and supply the output:
>
> Never knew time could list so many things :)
>
> /usr/bin/time --verbose sleep 0
>
> Command being timed: "sleep 0"
> User time (seconds): 0.00
> System time (seconds): 0.00
> Percent of CPU this job got: 16%
> Elapsed (wall clock) time (h:mm:ss or m:ss): 0:00.02
> Average shared text size (kbytes): 0
> Average unshared data size (kbytes): 0
> Average stack size (kbytes): 0
> Average total size (kbytes): 0
> Maximum resident set size (kbytes): 0
> Average resident set size (kbytes): 0
> Major (requiring I/O) page faults: 0
> Minor (reclaiming a frame) page faults: 48
> Voluntary context switches: 29
> Involuntary context switches: 1
> Swaps: 0
> File system inputs: 128
> File system outputs: 0
> Socket messages sent: 0
> Socket messages received: 0
> Signals delivered: 0
> Page size (bytes): 65536
> Exit status: 0
Thanks. Please try if the following patch fixes the segfault:
Index: test/testlfs.c
===================================================================
--- test/testlfs.c»·····(Revision 668795)
+++ test/testlfs.c»·····(Arbeitskopie)
@@ -251,7 +251,7 @@
{
apr_mmap_t *map;
apr_file_t *fh;
- apr_size_t len = 16384; /* hopefully a multiple of the page size */
+ apr_size_t len = 65536; /* hopefully a multiple of the page size */
apr_off_t off = eightGB - len;·
apr_status_t rv;
void *ptr;
If it does it is simply a bug in the testcase and we do not need to worry any
further. So IMHO in this case it would be nothing that would prevent us from
releasing 1.3.2.
Regards
Rüdiger
Re: [vote] Release apr[-util] 1.3.2
Posted by Lucian Adrian Grijincu <lu...@gmail.com>.
On Wed, Jun 18, 2008 at 01:04, Lucian Adrian Grijincu
<lu...@gmail.com> wrote:
> On Wed, Jun 18, 2008 at 00:57, Lucian Adrian Grijincu
> <lu...@gmail.com> wrote:
>> On Wed, Jun 18, 2008 at 00:53, Ruediger Pluem <rp...@apache.org> wrote:
>>> Please execute the following command on your box and supply the output:
>>
>> Never knew time could list so many things :)
>>
>> /usr/bin/time --verbose sleep 0
>> Page size (bytes): 65536
> offset/pagesize = 8589918208 / 65536 = 131071.75
> I guess the hardcoded value
> apr_size_t len = 16384; /* hopefully a multiple of the page size */
> from `test_mmap` is wrong.
I changed
apr_size_t len = 16384;
to
apr_size_t len = 65536;
It runs successfuly on both Ubuntu x86 and the misbehaving ppc64.
Now I stumbled on another one:
-bash-3.2$ ./testall testrand
testrand : |0x76,0x9c,0x8c,0xc2,0xb1,0x2e,0x6c,0x3b,
0x3f,0x46,0xd4,0xad,0x1d,0x48,0x47,0xe2,
0x21,0x7b,0xfb,0x48,0x17,0x0e,0x32,0xf6,
0x04,0x4f,0x97,0xd8,0xe6,0xda,0xb3,0x57,
0xa4,0xa4,0xc7,0x7e,0x3e,0x90,0xac,0x2c,
0xa0,0xa7,0x8b,0x7b,0xa0,0xff,0xe8,0xf8,
0x01,0x29,0xa6,0x44,0xf3,0x9e,0x47,0x97,
0xa4,0x28,0xdd,0x57,0xf8,0x11,0x47,0x61,
0xb5,0xb1,0x7e,0x90,0x6b,0xe8,0x83,0x5c,
0x78,0x1d,0x7e,0x64,0x95,0x35,0xce,0xa8,
0x20,0x9a,0x5c,0x38,0x25,0x2e,0xdd,0xe9,
0xdb,0xfd,0x04,0xd7,0xc1,0xe9,0x16,0xc7,
0xeb,0xe2,0xc5,0x80,0x3f,0xfe,0x3c,0x99,
0x92,0xcd,0x10,0x05,0x93,0xe3,0xb5,0xd6,
0xcf,0xbd,0xb3,0x52,0x75,0xcf,0x4c,0xef,
0x48,0x8b,0x86,0xb6,0x82,0x96,0x43,0xc6,
0x82,0x04,0xad,0xd2,0x0b,0xd5,0xac,0xda,
0x3d,0x85,0x58,0x38,0x54,0x6b,0x69,0x45,
0x37,0x4c,0xc7,0xd7,0x87,0xeb,0xbf,0xd9,
0xb1,0xb8,0xb8,0x2d,0x9b,0x33,0x6e,0x97,
0x04,0x1d,0x4c,0xb0,0xd1,0xdf,0x3d,0xac,
0xd2,0xaa,0xfa,0xcd,0x96,0xb7,0xcf,0xb1,
0x8e,0x3d,0xb3,0xe5,0x37,0xa9,0x95,0xb4,
0xaa,0x3d,0x11,0x1a,0x08,0x20,0x21,0x9f,
0xdb,0x08,0x3a,0xb9,0x57,0x9f,0xf2,0x1f,
0x27,0xdc,0xb6,0xc0,0x85,0x08,0x05,0xbb,
0x13,0xbe,0xb1,0xe9,0x63,0x2a,0xe2,0xa4,
0x23,0x15,0x2a,0x10,0xbf,0xdf,0x09,0xb3,
0xc7,0xfb,0x2d,0x87,0x48,0x19,0xfb,0xc0,
0x15,0x8c,0xcb,0xc6,0xbd,0x89,0x38,0x69,
0xa3,0xae,0xa3,0x21,0x58,0x50,0xe7,0xc4,
0x87,0xec,0x2e,0xb1,0x2d,0x6a,0xbd,0x46,
-0x21,0x61,0x4c,0x7a,0x4d,0x15,0x2f,0x32,
0x02,0x8f,0xd5,0x5f,0x07,0x27,0x4d,0x75,
0x37,0xf1,0xdf,0xcc,0x79,0x85,0x97,0xdd,
0xb8,0x48,0x79,0x78,0x4f,0x9f,0x7c,0x03,
0x17,0x22,0x3f,0x29,0xed,0x51,0x28,0x69,
0x95,0xa2,0x90,0xd8,0xa4,0xbe,0x12,0x3e,
0xc5,0x56,0x6a,0x3e,0xd0,0xf0,0x33,0xc9,
0x3c,0x95,0xf2,0xb5,0x36,0x44,0xeb,0x61,
0xc7,0x15,0x1b,0x7e,0xb0,0x9a,0xcb,0xe7,
0x4c,0x5f,0xf6,0xa1,0x64,0x79,0x99,0x08,
0x63,0x34,0x9a,0xc8,0xe3,0xb9,0xb8,0x17,
0x61,0x15,0x57,0x7d,0xdb,0xfb,0x13,0x6d,
0x27,0x54,0xfe,0x2c,0x8e,0xb9,0x84,0xd9,
0x73,0x9f,0x2e,0x46,0x69,0x51,0xb4,0x77,
0x6d,0x9e,0xa7,0x58,0xdc,0xe2,0x32,0x61,
0x4f,0x1c,0xef,0x83,0x27,0x84,0xb0,0xa5,
0x38,0x8f,0x01,0x29,0x5a,0x5c,0x1f,0xa8,
0x00,0xde,0x16,0x4c,0xe5,0xf7,0x1f,0x58,
0xc0,0x67,0xe2,0x98,0x3d,0xde,0x4a,0x75,
0x61,0x3f,0x23,0xd8,0x45,0x7a,0x10,0x60,
0x59,0x9b,0xd6,0xaf,0xcb,0x0a,0x2e,0x34,
0x9c,0x39,0x5b,0xd0,0xbc,0x9a,0xf0,0x7b,
0x7f,0x40,0x8b,0x33,0xc0,0x0e,0x2a,0x56,
0xfc,0xe5,0xab,0xde,0x7b,0x13,0xf5,0xec,
0x15,0x68,0xb8,0x09,0xbc,0x2c,0x15,0xf0,
0x7b,0xef,0x2a,0x97,0x19,0xa8,0x69,0x51,
0xdf,0xb0,0x5f,0x1a,0x4e,0xdf,0x42,0x02,
0x71,0x36,0xa7,0x25,0x64,0x85,0xe2,0x72,
0xc7,0x87,0x4d,0x7d,0x15,0xbb,0x15,0xd1,
0xb1,0x62,0x0b,0x25,0xd9,0xd3,0xd9,0x5a,
0xe3,0x47,0x1e,0xae,0x67,0xb4,0x19,0x9e,
0xed,0xd2,0xde,0xce,0x18,0x70,0x57,0x12,
\0x9e,0x89,0x6c,0x6a,0xb9,0x30,0xac,0x3e,
0x8c,0xe2,0xae,0x2b,0xa9,0x08,0x0e,0xbf,
0x28,0x26,0x44,0xff,0xde,0xd3,0x77,0xa6,
0x0b,0x32,0x46,0xf4,0x10,0xd7,0x02,0xa8,
0xb7,0xab,0x96,0x6d,0xe7,0x97,0x61,0xd4,
0xa7,0x30,0x8b,0xbc,0x6b,0x21,0xed,0x3c,
0x07,0xcb,0x22,0xaf,0x63,0x05,0xd7,0x7e,
0x1c,0xb5,0xbe,0xca,0x7e,0x40,0x36,0x2a,
0x3a,0xf1,0xcb,0x80,0xb7,0x99,0x0e,0x69,
0x00,0x9b,0x2a,0x60,0x92,0xc7,0x65,0x67,
0x9d,0x9e,0x92,0x2d,0x13,0x36,0x50,0x18,
0x54,0x65,0xb0,0xf2,0xa4,0x07,0x84,0x6d,
0x73,0x9b,0x7d,0x1d,0x8a,0xf7,0xbf,0xa3,
0x23,0x1f,0xc4,0x2c,0x0f,0x83,0x90,0x01,
0x1f,0xc8,0x6f,0x4c,0xf3,0x78,0xb5,0xf0,
0x59,0xea,0x22,0x88,0x5e,0x7f,0x18,0xec,
0xe8,0xe7,0xc9,0x45,0xe2,0x2a,0x54,0xb2,
0xdd,0xe0,0xf9,0xbc,0x3d,0xf9,0xce,0x3c,
0x4c,0xbd,0xc9,0xe2,0x20,0x4a,0x35,0x1c,
0x04,0x52,0x7f,0xb8,0x0f,0x60,0x89,0x63,
0x8a,0xbe,0x0a,0x44,0xac,0x5d,0xd8,0xeb,
0x24,0x7d,0xd1,0xda,0x4d,0x86,0x9b,0x94,
0x26,0x56,0x4a,0x5e,0x30,0xea,0xd4,0xa9,
0x9a,0xdf,0xdd,0xb6,0xb1,0x15,0xe0,0xfa,
0x28,0xa4,0xd6,0x95,0xa4,0xf1,0xd8,0x6e,
0xeb,0x8c,0xa4,0xac,0x34,0xfe,0x06,0x92,
0xc5,0x09,0x99,0x86,0xdc,0x5a,0x3c,0x92,
0xc8,0x3e,0x52,0x00,0x4d,0x01,0x43,0x6f,
0x69,0xcf,0xe2,0x60,0x9c,0x23,0xb3,0xa5,
0x5f,0x51,0x47,0x8c,0x07,0xde,0x60,0xc6,
0x04,0xbf,0x32,0xd6,0xdc,0xb7,0x31,0x01,
0x29,0x51,0x51,0xb3,0x19,0x6e,0xe4,0xf8,
/0xae,0x57,0xe1,0x77,0x09,0xb8,0x9f,0xd3,
0xb6,0x30,0x11,0xe7,0xa9,0xde,0x16,0xa0,
0xb5,0xe4,0x32,0xed,0x9c,0x8c,0x11,0xcc,
0x07,0x80,0x6e,0x61,0x00,0x32,0x2d,0x78,
0xe0,0xa3,0x0e,0xa3,0xe3,0xfb,0x65,0xa2,
0x24,0xa2,0x80,0xc8,0x5b,0x03,0xec,0x27,
0x2a,0xc0,0x27,0xc4,0x1b,0x4c,0xc8,0x2a,
0x82,0x43,0x88,0x74,0xb0,0x8d,0xcb,0xb8,
0x29,0x4c,0x53,0x62,0x11,0x11,0x79,0x76,
0xc8,0x0c,0xb6,0xf3,0xa3,0x1b,0xd4,0x42,
0x41,0x79,0x80,0x83,0xd6,0x5b,0x8e,0xb7,
0xd1,0x95,0x29,0x9d,0x48,0x3b,0x4d,0x3f,
0xd9,0xc8,0x7f,0xa6,0x01,0xb5,0x05,0xc3,
0x90,0x22,0x7a,0xc4,0x42,0x4d,0xe6,0xb2,
0xee,0x64,0xda,0x8e,0x15,0x57,0x72,0x88,
0x81,0xca,0x8f,0x9e,0x38,0xcc,0xa4,0x45,
0x7d,0x0e,0xc4,0x4e,0x3e,0xac,0x86,0x50,
0x37,0x95,0x7a,0x98,0x23,0x26,0xa7,0xbf,
0x60,0xfb,0xa3,0x70,0x90,0xc3,0x58,0xc6,
0xbd,0xd9,0x5e,0xa6,0x77,0x62,0x7a,0x5c,
0x96,0x83,0x7f,0x80,0x3d,0xf4,0x9c,0xcc,
0x9b,0x0c,0x8c,0xe1,0x72,0xa8,0xfb,0xc9,
0xc5,0x43,0x91,0xdc,0x9d,0x92,0xc2,0xce,
0x1c,0x5e,0x36,0xc7,0x87,0xb1,0xb4,0xa3,
0xc8,0x69,0x76,0xfc,0x35,0x75,0xcb,0x08,
0x2f,0xe3,0x98,0x76,0x37,0x80,0x04,0x5c,
0xb8,0xb0,0x7f,0xb2,0xda,0xe3,0xa3,0xba,
0xed,0xff,0xf5,0x9d,0x3b,0x7b,0xf3,0x32,
0x6c,0x50,0xa5,0x3e,0xcc,0xe1,0x84,0x9c,
0x17,0x9e,0x80,0x64,0x09,0xbb,0x62,0xf1,
0x95,0xf5,0x2c,0xc6,0x9f,0x6a,0xee,0x6d,
0x17,0x35,0x5f,0x35,0x8d,0x55,0x0c,0x07,
\0xcb,0x69,0x2a,0x56,0x21,0x9f,0x07,0x29,
0x3c,0x13,0xd0,0x56,0xd6,0x15,0x5f,0x68,
0x5e,0x62,0xe9,0x5e,0x3b,0x29,0xb3,0x82,
0x6b,0xef,0xe3,0x13,0xe1,0x81,0x2a,0x40,
0xdc,0x09,0x5a,0x4e,0x06,0xe0,0xc0,0x5c,
0x62,0x48,0xe2,0xe7,0x53,0xf5,0xa1,0x60,
0x73,0xe3,0x6c,0x1d,0x6c,0x7a,0x31,0xdd,
0x4c,0xe0,0x73,0x51,0x8c,0xa1,0x37,0x1c,
0x58,0x25,0xf1,0x51,0x43,0xdd,0x74,0x2c,
0xf1,0x7f,0x05,0x9a,0x7e,0xc2,0xf1,0x00,
0x8d,0x7a,0x39,0x60,0xd6,0xec,0x47,0xbe,
0xed,0x2c,0x10,0x0b,0xf9,0x31,0xf8,0x3d,
0x0a,0xf4,0x21,0xab,0x88,0xd2,0x52,0xaa,
0x7a,0x80,0x8f,0xeb,0x66,0xfa,0x10,0xeb,
0x20,0xc9,0x8d,0x87,0x2f,0xc3,0xa5,0xa4,
0xe6,0xcd,0xd4,0xd7,0x4d,0xed,0x81,0x4d,
0xac,0x93,0xd2,0x5c,0xc7,0xf5,0x8d,0xc2,
0xd8,0x8d,0xb6,0x7a,0x94,0xe1,0x83,0x4c,
0x26,0xe2,0x38,0x6d,0xf5,0xbd,0x9d,0x6e,
0x91,0x77,0x3a,0x4b,0x9b,0xef,0x9b,0xa3,
0x9f,0xf6,0x6d,0x0c,0xdc,0x4b,0x02,0xe9,
0x5d,0x3d,0xfc,0x92,0x6b,0xdf,0xc9,0xef,
0xb9,0xa8,0x74,0x09,0xa3,0xff,0x64,0x8d,
0x19,0xc1,0x31,0x31,0x17,0xe1,0xb7,0x7a,
0xe7,0x55,0x14,0x92,0x05,0xe3,0x1e,0xb8,
0x9b,0x1b,0xdc,0xac,0x0e,0x15,0x08,0xa2,
0x93,0x13,0xf6,0x04,0xc6,0x9d,0xf8,0x7f,
0x26,0x32,0x68,0x43,0x2e,0x5a,0x4f,0x47,
0xe8,0xf8,0x59,0xb7,0xfb,0xbe,0x30,0x04,
0xb6,0x63,0x6f,0x19,0xf3,0x2c,0xd4,0xeb,
0x32,0x8a,0x54,0x01,0xd0,0xaf,0x3f,0x13,
0xc1,0x7f,0x10,0x2e,0x08,0x1c,0x28,0x4b,
FAILED 5 of 9
Failed Tests Total Fail Failed %
===================================================
testrand 9 5 55.56%
--
Lucian
Re: [vote] Release apr[-util] 1.3.2
Posted by Lucian Adrian Grijincu <lu...@gmail.com>.
On Wed, Jun 18, 2008 at 00:57, Lucian Adrian Grijincu
<lu...@gmail.com> wrote:
> On Wed, Jun 18, 2008 at 00:53, Ruediger Pluem <rp...@apache.org> wrote:
>> Please execute the following command on your box and supply the output:
>
> Never knew time could list so many things :)
>
> /usr/bin/time --verbose sleep 0
> Page size (bytes): 65536
offset/pagesize = 8589918208 / 65536 = 131071.75
I guess the hardcoded value
apr_size_t len = 16384; /* hopefully a multiple of the page size */
from `test_mmap` is wrong.
--
Lucian
Re: [vote] Release apr[-util] 1.3.2
Posted by Lucian Adrian Grijincu <lu...@gmail.com>.
On Wed, Jun 18, 2008 at 00:53, Ruediger Pluem <rp...@apache.org> wrote:
> Please execute the following command on your box and supply the output:
Never knew time could list so many things :)
/usr/bin/time --verbose sleep 0
Command being timed: "sleep 0"
User time (seconds): 0.00
System time (seconds): 0.00
Percent of CPU this job got: 16%
Elapsed (wall clock) time (h:mm:ss or m:ss): 0:00.02
Average shared text size (kbytes): 0
Average unshared data size (kbytes): 0
Average stack size (kbytes): 0
Average total size (kbytes): 0
Maximum resident set size (kbytes): 0
Average resident set size (kbytes): 0
Major (requiring I/O) page faults: 0
Minor (reclaiming a frame) page faults: 48
Voluntary context switches: 29
Involuntary context switches: 1
Swaps: 0
File system inputs: 128
File system outputs: 0
Socket messages sent: 0
Socket messages received: 0
Signals delivered: 0
Page size (bytes): 65536
Exit status: 0
FWIW,
-bash-3.2$ ulimit -a
core file size (blocks, -c) 0
data seg size (kbytes, -d) unlimited
scheduling priority (-e) 0
file size (blocks, -f) unlimited
pending signals (-i) 8192
max locked memory (kbytes, -l) 512
max memory size (kbytes, -m) unlimited
open files (-n) 1024
pipe size (512 bytes, -p) 8
POSIX message queues (bytes, -q) 819200
real-time priority (-r) 0
stack size (kbytes, -s) 10240
cpu time (seconds, -t) unlimited
max user processes (-u) 8192
virtual memory (kbytes, -v) unlimited
file locks (-x) unlimited
--
Lucian
Re: [vote] Release apr[-util] 1.3.2
Posted by Ruediger Pluem <rp...@apache.org>.
On 06/17/2008 10:37 PM, Lucian Adrian Grijincu wrote:
> On Tue, Jun 17, 2008 at 22:24, Ruediger Pluem <rp...@apache.org> wrote:
>> Thanks for investigating, but keep two things in mind:
>>
>> 1. If errno is really 0 it would be a bug in your glibc / Linux kernel
>> as the man page is very clear about setting an error code in errno here.
>
> Yeah, but if it /would/ be a bug in glibc shouldn't APR route around
> the error somehow?
> It's not an error, gdb was wrong.
>
>> 2. I don't trust print errno here as errno in threaded environments (I
>> assume
>> you compiled APR with thread support) is not a static variable as it was
>> in the past, but a macro wrapping something different in order to make the
>> whole errno process thread safe. So I guess it would be much safer here to
>> print the value that is returned in the calling function. Of course in our
>> case this is more difficult as the call is convoluted in a macro.
>> Maybe you can call apr_mmap_create(&map, fh, off, len, APR_MMAP_READ, p));
>> directly instead via APR_ASSERT_SUCCESS, assign the return value to a
>> variable
>> and do a print via gdb afterwards.
> apr_mmap_create returns 22 (Invalid argument).
>
> │133 mm = mmap(NULL, size, native_flags, MAP_SHARED,
> file->filedes, offset);
> (gdb) print size
> $3 = 16384
> (gdb) print offset
> $4 = 8589918208
>
> man 2 mmap says:
>> void *mmap(void *start, size_t length, int prot, int flags, int fd, off_t offset);
>
>> EINVAL (since Linux 2.6.12), length was 0.
> this cannot be it.
>
>> EINVAL flags contained neither MAP_PRIVATE or MAP_SHARED, or contained both of these values.
> neither can this.
>
>> EINVAL We don't like start, length, or offset (e.g., they are too large, or not aligned on a page boundary).
> start=0
> length=16384
> offset=8589918208
>
> Any ideas?
Please execute the following command on your box and supply the output:
/usr/bin/time --verbose sleep 0
Regards
Rüdiger
Re: [vote] Release apr[-util] 1.3.2
Posted by Lucian Adrian Grijincu <lu...@gmail.com>.
On Tue, Jun 17, 2008 at 22:24, Ruediger Pluem <rp...@apache.org> wrote:
> Thanks for investigating, but keep two things in mind:
>
> 1. If errno is really 0 it would be a bug in your glibc / Linux kernel
> as the man page is very clear about setting an error code in errno here.
Yeah, but if it /would/ be a bug in glibc shouldn't APR route around
the error somehow?
It's not an error, gdb was wrong.
> 2. I don't trust print errno here as errno in threaded environments (I
> assume
> you compiled APR with thread support) is not a static variable as it was
> in the past, but a macro wrapping something different in order to make the
> whole errno process thread safe. So I guess it would be much safer here to
> print the value that is returned in the calling function. Of course in our
> case this is more difficult as the call is convoluted in a macro.
> Maybe you can call apr_mmap_create(&map, fh, off, len, APR_MMAP_READ, p));
> directly instead via APR_ASSERT_SUCCESS, assign the return value to a
> variable
> and do a print via gdb afterwards.
apr_mmap_create returns 22 (Invalid argument).
│133 mm = mmap(NULL, size, native_flags, MAP_SHARED,
file->filedes, offset);
(gdb) print size
$3 = 16384
(gdb) print offset
$4 = 8589918208
man 2 mmap says:
> void *mmap(void *start, size_t length, int prot, int flags, int fd, off_t offset);
> EINVAL (since Linux 2.6.12), length was 0.
this cannot be it.
> EINVAL flags contained neither MAP_PRIVATE or MAP_SHARED, or contained both of these values.
neither can this.
> EINVAL We don't like start, length, or offset (e.g., they are too large, or not aligned on a page boundary).
start=0
length=16384
offset=8589918208
Any ideas?
--
Lucian
Re: [vote] Release apr[-util] 1.3.2
Posted by Ruediger Pluem <rp...@apache.org>.
On 06/17/2008 08:55 PM, Lucian Adrian Grijincu wrote:
> On Tue, Jun 17, 2008 at 19:25, Lucian Adrian Grijincu
> <lu...@gmail.com> wrote:
>> On Tue, Jun 17, 2008 at 16:40, William A. Rowe, Jr. <wr...@rowe-clan.net> wrote:
>>> Candidates will be up at http://apr.apache.org/dev/dist/ once the sync
>>> happens within the hour... vote away;
>> A Cell Blade system: Linux 2.6.22-5.20070920bsc #1 SMP Tue Sep 25
>> 10:49:16 CEST 2007 ppc64 ppc64 ppc64 GNU/Linux
>>
>>
>>> [-1] Release apr 1.3.2 as GA
>> -bash-3.2$ ./testall testlfs
>> testlfs : |Segmentation fault
>
> It seems that in `apr_mmap_create` on this system `mmap` returns
> MAP_FAILED == (void *)-1 but does not set `errno` to an appropriate
> value:
> │133 mm = mmap(NULL, size, native_flags, MAP_SHARED,
> file->filedes, offset);
> │134
> │135 if (mm == (void *)-1) {
> │136 /* we failed to get an mmap'd file... */
> │137 *new = NULL;
> >│138 return errno;
> │139 }
> (gdb) print mm
> $2 = (void *) 0xffffffff
> (gdb) print errno
> $5 = 0
Thanks for investigating, but keep two things in mind:
1. If errno is really 0 it would be a bug in your glibc / Linux kernel
as the man page is very clear about setting an error code in errno here.
2. I don't trust print errno here as errno in threaded environments (I assume
you compiled APR with thread support) is not a static variable as it was
in the past, but a macro wrapping something different in order to make the
whole errno process thread safe. So I guess it would be much safer here to
print the value that is returned in the calling function. Of course in our
case this is more difficult as the call is convoluted in a macro.
Maybe you can call apr_mmap_create(&map, fh, off, len, APR_MMAP_READ, p));
directly instead via APR_ASSERT_SUCCESS, assign the return value to a variable
and do a print via gdb afterwards.
Regards
Rüdiger
Re: [vote] Release apr[-util] 1.3.2
Posted by Lucian Adrian Grijincu <lu...@gmail.com>.
On Tue, Jun 17, 2008 at 19:25, Lucian Adrian Grijincu
<lu...@gmail.com> wrote:
> On Tue, Jun 17, 2008 at 16:40, William A. Rowe, Jr. <wr...@rowe-clan.net> wrote:
>> Candidates will be up at http://apr.apache.org/dev/dist/ once the sync
>> happens within the hour... vote away;
> A Cell Blade system: Linux 2.6.22-5.20070920bsc #1 SMP Tue Sep 25
> 10:49:16 CEST 2007 ppc64 ppc64 ppc64 GNU/Linux
>
>
>> [-1] Release apr 1.3.2 as GA
> -bash-3.2$ ./testall testlfs
> testlfs : |Segmentation fault
It seems that in `apr_mmap_create` on this system `mmap` returns
MAP_FAILED == (void *)-1 but does not set `errno` to an appropriate
value:
│133 mm = mmap(NULL, size, native_flags, MAP_SHARED,
file->filedes, offset);
│134
│135 if (mm == (void *)-1) {
│136 /* we failed to get an mmap'd file... */
│137 *new = NULL;
>│138 return errno;
│139 }
(gdb) print mm
$2 = (void *) 0xffffffff
(gdb) print errno
$5 = 0
Should we check whether `errno` is 0 and if it is should we return a
default error?
Because `apr_mmap_create` returns errno=0=APR_SUCCESS the tests
believe that `map` is set to an appropriate value and then proceed to
dereference it:
│265 APR_ASSERT_SUCCESS(tc, "mmap 8GB file",
│266 apr_mmap_create(&map, fh, off, len,
APR_MMAP_READ, p));
│267
│268 APR_ASSERT_SUCCESS(tc, "close file", apr_file_close(fh));
│269
>│270 ABTS_ASSERT(tc, "mapped a 16K block", map->size == len);
(gdb) print map
$8 = (apr_mmap_t *) 0x0
(gdb) n
Program received signal SIGSEGV, Segmentation fault.
0x10023aa4 in test_mmap (tc=0xffe4f73c, data=0x0) at testlfs.c:270
--
Lucian
Re: [vote] Release apr[-util] 1.3.2
Posted by Lucian Adrian Grijincu <lu...@gmail.com>.
On Tue, Jun 17, 2008 at 22:11, Ruediger Pluem <rp...@apache.org> wrote:
>
>
>> A Cell Blade system: Linux 2.6.22-5.20070920bsc #1 SMP Tue Sep 25
>> 10:49:16 CEST 2007 ppc64 ppc64 ppc64 GNU/Linux
>>
>>
>>> [-1] Release apr 1.3.2 as GA
>>
>> -bash-3.2$ ./testall testlfs
>> testlfs : |Segmentation fault
>> I'll try and figure it out sometime later.
>
> I guess a gdb backtrace would be very useful to share.
>
addressed in another mail.
>>
>>> [-1] Release apr-util 1.3.2 as GA
>
> What the reason for your -1 here. I cannot see anything wrong
> below.
....
>> ======== invalid op ========
>> invalid op returned 1 (should be nonzero). Error msg follows
Sorry. I'm a moron. I misread the above message as "invalid op
returned 1 (should be ZERO)". -ENOCOFFEE.
--
Lucian
Re: [vote] Release apr[-util] 1.3.2
Posted by Ruediger Pluem <rp...@apache.org>.
On 06/17/2008 06:25 PM, Lucian Adrian Grijincu wrote:
> On Tue, Jun 17, 2008 at 16:40, William A. Rowe, Jr. <wr...@rowe-clan.net> wrote:
>> Candidates will be up at http://apr.apache.org/dev/dist/ once the sync
>> happens within the hour... vote away;
> A Cell Blade system: Linux 2.6.22-5.20070920bsc #1 SMP Tue Sep 25
> 10:49:16 CEST 2007 ppc64 ppc64 ppc64 GNU/Linux
>
>
>> [-1] Release apr 1.3.2 as GA
> -bash-3.2$ ./testall testlfs
> testlfs : |Segmentation fault
> I'll try and figure it out sometime later.
I guess a gdb backtrace would be very useful to share.
>
>> [-1] Release apr-util 1.3.2 as GA
What the reason for your -1 here. I cannot see anything wrong
below.
> [snip]
> All tests passed.
> Failed to load driver file apr_dbd_sqlite2.so
> Loaded sqlite3 driver OK.
> Opened sqlite3[] OK
> ======== create table ========
> create table test successful
>
> ======== insert rows ========
> insert rows test successful
>
> ======== invalid op ========
> invalid op returned 1 (should be nonzero). Error msg follows
> 'no such table: apr_dbd_test1'
> valid op returned 0 (should be zero; error shouldn't affect subsequent ops)
> invalid op test successful
>
> ======== select random ========
> ROW 5: wibble nothing 5
> ROW 1: asdfgh bar 1
> select random test successful
>
> ======== select sequential ========
> ROW 1: asdfgh bar 1
> ROW 2: bar foo (null)
> ROW 3: foo (null) (null)
> ROW 4: qwerty foo 0
> ROW 5: wibble nothing 5
> ROW 6: wibble other 5
> select sequential test successful
>
> ======== transactions ========
> Transaction 1
> 6 rows updated
> Valid insert returned 1. Should be nonzero (fail) because transaction is bad
> Transaction ended (should be rollback) - viewing table
> A column of "failed" indicates transaction failed (no rollback)
> ROW 1: asdfgh bar 1
> ROW 2: bar foo (null)
> ROW 3: foo (null) (null)
> ROW 4: qwerty foo 0
> ROW 5: wibble nothing 5
> ROW 6: wibble other 5
> Transaction 2
> 6 rows updated
> Valid insert returned 0. Should be zero (OK)
> Transaction ended (should be commit) - viewing table
> ROW 1: aaa zzz 3
> ROW 2: asdfgh success 1
> ROW 3: bar success (null)
> ROW 4: foo success (null)
> ROW 5: qwerty success 0
> ROW 6: wibble success 5
> ROW 7: wibble success 5
> transactions test successful
>
> ======== prepared select ========
> Selecting rows where col3 <= 3 and bar row where it's unset.
> Should show four rows.
> ROW 1: qwerty success 0
> ROW 2: asdfgh success 1
> ROW 3: bar success (null)
> ROW 4: aaa zzz 3
> prepared select test successful
>
> ======== prepared query ========
> Showing table (should now contain row "prepared insert 2")
> ROW 1: aaa zzz 3
> ROW 2: asdfgh success 1
> ROW 3: bar success (null)
> ROW 4: foo success (null)
> ROW 5: prepared insert 2
> ROW 6: qwerty success 0
> ROW 7: wibble success 5
> ROW 8: wibble success 5
> prepared query test successful
>
> ======== drop table ========
> drop table test successful
>
>
>
Regards
Rüdiger
Re: [vote] Release apr[-util] 1.3.2
Posted by Lucian Adrian Grijincu <lu...@gmail.com>.
On Tue, Jun 17, 2008 at 16:40, William A. Rowe, Jr. <wr...@rowe-clan.net> wrote:
> Candidates will be up at http://apr.apache.org/dev/dist/ once the sync
> happens within the hour... vote away;
A Cell Blade system: Linux 2.6.22-5.20070920bsc #1 SMP Tue Sep 25
10:49:16 CEST 2007 ppc64 ppc64 ppc64 GNU/Linux
> [-1] Release apr 1.3.2 as GA
-bash-3.2$ ./testall testlfs
testlfs : |Segmentation fault
I'll try and figure it out sometime later.
> [-1] Release apr-util 1.3.2 as GA
[snip]
All tests passed.
Failed to load driver file apr_dbd_sqlite2.so
Loaded sqlite3 driver OK.
Opened sqlite3[] OK
======== create table ========
create table test successful
======== insert rows ========
insert rows test successful
======== invalid op ========
invalid op returned 1 (should be nonzero). Error msg follows
'no such table: apr_dbd_test1'
valid op returned 0 (should be zero; error shouldn't affect subsequent ops)
invalid op test successful
======== select random ========
ROW 5: wibble nothing 5
ROW 1: asdfgh bar 1
select random test successful
======== select sequential ========
ROW 1: asdfgh bar 1
ROW 2: bar foo (null)
ROW 3: foo (null) (null)
ROW 4: qwerty foo 0
ROW 5: wibble nothing 5
ROW 6: wibble other 5
select sequential test successful
======== transactions ========
Transaction 1
6 rows updated
Valid insert returned 1. Should be nonzero (fail) because transaction is bad
Transaction ended (should be rollback) - viewing table
A column of "failed" indicates transaction failed (no rollback)
ROW 1: asdfgh bar 1
ROW 2: bar foo (null)
ROW 3: foo (null) (null)
ROW 4: qwerty foo 0
ROW 5: wibble nothing 5
ROW 6: wibble other 5
Transaction 2
6 rows updated
Valid insert returned 0. Should be zero (OK)
Transaction ended (should be commit) - viewing table
ROW 1: aaa zzz 3
ROW 2: asdfgh success 1
ROW 3: bar success (null)
ROW 4: foo success (null)
ROW 5: qwerty success 0
ROW 6: wibble success 5
ROW 7: wibble success 5
transactions test successful
======== prepared select ========
Selecting rows where col3 <= 3 and bar row where it's unset.
Should show four rows.
ROW 1: qwerty success 0
ROW 2: asdfgh success 1
ROW 3: bar success (null)
ROW 4: aaa zzz 3
prepared select test successful
======== prepared query ========
Showing table (should now contain row "prepared insert 2")
ROW 1: aaa zzz 3
ROW 2: asdfgh success 1
ROW 3: bar success (null)
ROW 4: foo success (null)
ROW 5: prepared insert 2
ROW 6: qwerty success 0
ROW 7: wibble success 5
ROW 8: wibble success 5
prepared query test successful
======== drop table ========
drop table test successful
--
Lucian
Re: [vote] Release apr[-util] 1.3.2
Posted by Brad Nicholes <BN...@novell.com>.
>>> On 6/17/2008 at 7:40 AM, in message <48...@rowe-clan.net>, "William
A. Rowe, Jr." <wr...@rowe-clan.net> wrote:
> Candidates will be up at http://apr.apache.org/dev/dist/ once the sync
> happens within the hour... vote away;
>
> +/-1
> [ ] Release apr 1.3.2 as GA
> [ ] Release apr-util 1.3.2 as GA
>
>
> Of course 1.3.1 images were scuttled, thanks to all who tested! Windows
> .zip's will follow after a bit of initial response for unix.
+1 Netware
Re: [vote] Release apr[-util] 1.3.2
Posted by Oden Eriksson <oe...@mandriva.com>.
Den Tuesday 17 June 2008 15:40:06 skrev William A. Rowe, Jr.:
> Candidates will be up at http://apr.apache.org/dev/dist/ once the sync
> happens within the hour... vote away;
>
> +/-1
> [ ] Release apr 1.3.2 as GA
> [ ] Release apr-util 1.3.2 as GA
>
>
> Of course 1.3.1 images were scuttled, thanks to all who tested! Windows
> .zip's will follow after a bit of initial response for unix.
All tests passed in Cooker.
Re: showstoppers to 1.3.3?
Posted by Bojan Smojver <bo...@rexursive.com>.
On Mon, 2008-06-30 at 15:12 -0500, William A. Rowe, Jr. wrote:
> Are there any other showstoppers to trying a 1.3.3 release that folks will
> volunteer to solve in the very near term?
I have all tests passing on Fedora 9 i686 for both APR and APU for 1.3.x
branch. I don't see any new Bugzilla entries as show stoppers on Unix
flavours.
--
Bojan
showstoppers to 1.3.3?
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
William A. Rowe, Jr. wrote:
>
> I can see we'll be making a 1.3.3 within a week or so for autoconf, but
> I'd like to have the dust settle on the patches committed today. Once
> everyone's happy with 1.3.x branch, let's get that tagged so httpd can
> replace 2.2.9 - it's obvious we have a whole lot of users confused by
> the noisy ./configure script :(
With all the commotion this weekend, I hoped to have a mingw/msys toolchain
up over the weekend and fix those bugs, but got too busy.
I'd still like to get those solved in the next day or two, thanks for all
the mingw/msys reports to the list.
Are there any other showstoppers to trying a 1.3.3 release that folks will
volunteer to solve in the very near term?
Bill
[results][vote] Release apr[-util] 1.3.2
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
William A. Rowe, Jr. wrote:
> Candidates will be up at http://apr.apache.org/dev/dist/ once the sync
> happens within the hour... vote away;
I've counted enough +1's for release of these packages, they are going up
to the site and mirrors are syncing, I'll send the announce about 12-18
hours from now. Thanks all for testing!
I can see we'll be making a 1.3.3 within a week or so for autoconf, but
I'd like to have the dust settle on the patches committed today. Once
everyone's happy with 1.3.x branch, let's get that tagged so httpd can
replace 2.2.9 - it's obvious we have a whole lot of users confused by
the noisy ./configure script :(
Bill
Re: [vote] Release apr[-util] 1.3.2
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
> [+1] Release apr 1.3.2 as GA
> [+1] Release apr-util 1.3.2 as GA
My own belated vote for hpux (ansic) aix (vac) solaris (sunstudio c),
linux and windows.
Didn't like the noise from autoconf that we inherit in 2.62 nor the
breakage in the static util test on windows, and I'll be fixing the
later, later. Neither was a showstopper IMHO, this is progress.
Bill
Re: [vote] Release apr[-util] 1.3.2
Posted by Ruediger Pluem <rp...@apache.org>.
On 06/17/2008 03:40 PM, William A. Rowe, Jr. wrote:
> Candidates will be up at http://apr.apache.org/dev/dist/ once the sync
> happens within the hour... vote away;
>
> +/-1
> [ +1 ] Release apr 1.3.2 as GA
> [ +1 ] Release apr-util 1.3.2 as GA
>
>
Passes all tests on the following platforms:
RHEL 3 32 Bit
RHEL 4 32 Bit
RHEL 4 64 Bit
SuSE Linux 10.2 32 Bit
SuSE Linux 10.1 64 Bit
Solaris 8 SPARC 32 Bit binary
Solaris 9 SPARC 32 Bit binary
Solaris 10 SPARC 32 Bit binary
Regards
Rüdiger