You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by michaelsembwever <gi...@git.apache.org> on 2018/05/15 21:49:54 UTC
[GitHub] cassandra-dtest pull request #29: Remove doxygen and references to it
GitHub user michaelsembwever opened a pull request:
https://github.com/apache/cassandra-dtest/pull/29
Remove doxygen and references to it
@ptnapoleon as requested and discussed https://wilderness.apache.org/channels/?f=cassandra-dev/2018-05-14#1526273434
I left most of the docstrings section, just renaming it to "Documentatin" as I think these comments still have purpose in the code (they just don't need to be doxygen generated to another place).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/thelastpickle/cassandra-dtest mck/remove-doxygen
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cassandra-dtest/pull/29.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #29
----
commit 0fd9a55b964bee4218d5d617895be9fa34a49985
Author: Mick Semb Wever <mc...@...>
Date: 2018-05-15T21:44:30Z
Remove doxygen and references to it.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] cassandra-dtest pull request #29: Remove doxygen and references to it
Posted by michaelsembwever <gi...@git.apache.org>.
Github user michaelsembwever commented on a diff in the pull request:
https://github.com/apache/cassandra-dtest/pull/29#discussion_r188447578
--- Diff: CONTRIBUTING.md ---
@@ -82,7 +62,6 @@ In some cases, we organize our test files by putting them in directories. If you
- When possible, you should use the assert functions from [`tools/assertions.py`](https://github.com/apache/cassandra-dtest/blob/master/tools/assertions.py).
- When none of these are applicable, use python's built in [unittest assertions](https://docs.python.org/2/library/unittest.html#assert-methods).
-- Naked assert statements should never be used, e.g. `assert True`
--- End diff --
Also took this out, as it's clearly not adhered to in the codebase.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] cassandra-dtest issue #29: Remove doxygen and references to it
Posted by ptnapoleon <gi...@git.apache.org>.
Github user ptnapoleon commented on the issue:
https://github.com/apache/cassandra-dtest/pull/29
+1! And yes, that naked assert line probably should have been caught with the move to pytest. Nice catch.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] cassandra-dtest issue #29: Remove doxygen and references to it
Posted by michaelsembwever <gi...@git.apache.org>.
Github user michaelsembwever commented on the issue:
https://github.com/apache/cassandra-dtest/pull/29
Merged. But I forgot to standardise the commit message, my bad.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] cassandra-dtest pull request #29: Remove doxygen and references to it
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cassandra-dtest/pull/29
---
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org