You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by twalthr <gi...@git.apache.org> on 2017/05/16 12:25:48 UTC
[GitHub] flink pull request #3923: [FLINK-6587] [table] Simplification and bug fixing...
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/3923
[FLINK-6587] [table] Simplification and bug fixing of the ExpressionParser
This PR fixes several issues related to the ExpressionParser and the resolution of expression produced by it. Only special cases are handled by the parser, other expressions will resolved by the function catalog. I also updated the data types such that they are in sync with `org.apache.flink.table.api.Types`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/twalthr/flink FLINK-6587
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3923.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3923
----
commit 2269ebbd33f6ed744fd68c2771599a07dcb49970
Author: twalthr <tw...@apache.org>
Date: 2017-05-15T13:27:10Z
[FLINK-6587] [table] Simplification and bug fixing of the ExpressionParser
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3923: [FLINK-6587] [table] Simplification and bug fixing...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3923
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3923: [FLINK-6587] [table] Simplification and bug fixing of the...
Posted by shaoxuan-wang <gi...@git.apache.org>.
Github user shaoxuan-wang commented on the issue:
https://github.com/apache/flink/pull/3923
@twalthr, it seems we have reserved the keyword with the case insensitive. For instance, we cannot use "Sum" and "SUM", as "sum" is reserved. Did we intent to filter the keyword like this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3923: [FLINK-6587] [table] Simplification and bug fixing of the...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3923
The PR looks good to me. +1 from my side.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3923: [FLINK-6587] [table] Simplification and bug fixing of the...
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/3923
@shaoxuan-wang the function catalog is case insensitive anyway. With this PR we have almost no keywords anymore. So a "sum" could be overwritten by "SUM".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3923: [FLINK-6587] [table] Simplification and bug fixing of the...
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/3923
Thanks @fhueske. I will merge this and update the documentation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---