You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Will Berkeley (Code Review)" <ge...@cloudera.org> on 2017/06/01 23:37:36 UTC
[kudu-CR](gh-pages) WIP: Kudu Consistency Blog Post Pt1
Will Berkeley has posted comments on this change.
Change subject: WIP: Kudu Consistency Blog Post Pt1
......................................................................
Patch Set 3:
(30 comments)
http://gerrit.cloudera.org:8080/#/c/7019/3/_posts/2017-05-30-kudu-consistency-pt1.md
File _posts/2017-05-30-kudu-consistency-pt1.md:
PS3, Line 6: multi-part short blog post series
nit: series of short blog posts (multi-part implied by "series")
PS3, Line 7: and
nit: , and
PS3, Line 10: follow up
follow-up
PS3, Line 15: :
nit: ? instead of :
PS3, Line 17: users and requests
: are executed by many different machines,
> how about, "...users, and must serve requests across numerous machines,..."
Howabout: "...users while coordinating requests across many machines"
PS3, Line 21: ,
remove
PS3, Line 24: making writing correct applications against it easy to code and reason about
Howabout: "making correct applications easy to code and reason about" or "making it easy to code and reason about applications"
PS3, Line 25: ordering anomalies
Can you add a short explanation or example of an ordering anomaly?
PS3, Line 29: single machine
single-machine
PS3, Line 29: ,
nit: remove
PS3, Line 31: are designed to be distributed,
: which means that there are many more things that can fail, and must take store and process data
: on many machines/cores, which means that many things happen at the same time in different locations
howabout: "are designed to be distributed, storing and processing data across many machines and cores, which means that many things happen simultaneously in different locations and that there are more pieces that can fail"
PS3, Line 34:
with
PS3, Line 34: with
remove
PS3, Line 35:
-
PS3, Line 35: single thread
single-threaded
PS3, Line 35:
nit: I prefer a comma here to split up the two compound adjectives
PS3, Line 36: where failures are common and many things happen at the same time
nit: surround with ,'s
PS3, Line 43: ,
;
Line 45: ## Motivation behind the consistency design decisions in Kudu:
> Can we assume the reader understands what a tradeoff is? If we can, I think
I like the first paragraph as an introduction to design tradeoffs, even knowing what a tradeoff is. I agree that the section is about design tradeoffs in general and not just consistency design, so it should be retitled.
PS3, Line 49: a term from machine learning
I thought "no such thing as a free lunch" came from economics
PS3, Line 49: trade offs
trade-offs or tradeoffs (consistently one or the other)
PS3, Line 61: which is
remove
PS3, Line 67: is
are
PS3, Line 74: architecture
architectural
PS3, Line 74: for analytics
remove
PS3, Line 95: semantics
> "guarantees", "constraints"?
FWIW I think semantics is a good word here
PS3, Line 123: This
The
PS3, Line 130: landed
> "been added to"?
I'd say "until it has been written to the WAL of a majority of replicas", just to be precise that the request must be persisted on a majority of replicas.
PS3, Line 132:
:
PS3, Line 136: Scans take a snapshots
> "A scan will take a snapshot"
I think "Scans take a snapshot"
--
To view, visit http://gerrit.cloudera.org:8080/7019
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icaec0c8ace20651a65901a8e1786e785265540d1
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes