You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "yaooqinn (via GitHub)" <gi...@apache.org> on 2026/01/20 07:07:22 UTC
[PR] [SPARK-54374][SQL][UI] Enlarge the SVG viewBox attribute of SQL plan visualization initialization [spark]
yaooqinn opened a new pull request, #53864:
URL: https://github.com/apache/spark/pull/53864
### What changes were proposed in this pull request?
This is a follow-up to SPARK-54373. Enlarge the SVG viewBox attribute of SQL plan visualization initialization from a 100×100 window to an available width of the window × 1000.
### Why are the changes needed?
Improve the visualization quality while the SQL plan graphics are being painted, consistent with the improvement made to Job DAG in SPARK-54373.
### Does this PR introduce _any_ user-facing change?
No, the final sizes of these SVGs will be adjusted to the actual needs.
### How was this patch tested?
Tested in Chrome DevTools.
### Was this patch authored or co-authored using generative AI tooling?
Yes, GitHub Copilot was used to assist with reviewing SPARK-54373 and applying the same pattern to spark-sql-viz.js.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54374][SQL][UI] Enlarge the SVG viewBox attribute of SQL plan visualization initialization [spark]
Posted by "sarutak (via GitHub)" <gi...@apache.org>.
sarutak commented on PR #53864:
URL: https://github.com/apache/spark/pull/53864#issuecomment-3959437067
@yaooqinn If your concern is the initial width and height, your suggestion LGTM. Feel free to open a PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54374][SQL][UI] Enlarge the SVG viewBox attribute of SQL plan visualization initialization [spark]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #53864:
URL: https://github.com/apache/spark/pull/53864#issuecomment-3889339344
this change causes some issues in the UI display
before
<img width="811" height="746" alt="image" src="https://github.com/user-attachments/assets/a7dc9db6-ede8-4d8e-9504-e3e2282f1ef9" />
after
<img width="770" height="726" alt="image" src="https://github.com/user-attachments/assets/ea062596-fe25-456d-980d-af954cf9fc6e" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54374][SQL][UI] Enlarge the SVG viewBox attribute of SQL plan visualization initialization [spark]
Posted by "sarutak (via GitHub)" <gi...@apache.org>.
sarutak closed pull request #53864: [SPARK-54374][SQL][UI] Enlarge the SVG viewBox attribute of SQL plan visualization initialization
URL: https://github.com/apache/spark/pull/53864
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54374][SQL][UI] Enlarge the SVG viewBox attribute of SQL plan visualization initialization [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #53864:
URL: https://github.com/apache/spark/pull/53864#issuecomment-3959239261
@sarutak Have you tried this fix? — instead of setting viewBox (which changes the coordinate system), set only width and height on the initial SVG:
```gitdiff
function renderPlanViz() {
- var svg = planVizContainer()
- .append("svg")
- .attr("viewBox", `${-PlanVizConstants.svgMarginX} ${-PlanVizConstants.svgMarginY} ${window.innerWidth || 1920} 1000`);
+ var svg = planVizContainer()
+ .append("svg")
+ .attr("width", window.innerWidth || 1920)
+ .attr("height", 1000);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54374][SQL][UI] Enlarge the SVG viewBox attribute of SQL plan visualization initialization [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #53864:
URL: https://github.com/apache/spark/pull/53864#issuecomment-3772613800
thank you @sarutak
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54374][SQL][UI] Enlarge the SVG viewBox attribute of SQL plan visualization initialization [spark]
Posted by "sarutak (via GitHub)" <gi...@apache.org>.
sarutak commented on PR #53864:
URL: https://github.com/apache/spark/pull/53864#issuecomment-3772039638
Merging to `master`. The GA failure doesn't seem relevant to this change.
Thank you @yaooqinn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54374][SQL][UI] Enlarge the SVG viewBox attribute of SQL plan visualization initialization [spark]
Posted by "sarutak (via GitHub)" <gi...@apache.org>.
sarutak commented on PR #53864:
URL: https://github.com/apache/spark/pull/53864#issuecomment-3899051579
@pan3793
Thank you for letting me know the issue. I'll look into it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54374][SQL][UI] Enlarge the SVG viewBox attribute of SQL plan visualization initialization [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #53864:
URL: https://github.com/apache/spark/pull/53864#issuecomment-3771358220
## JIRA Issue Information
=== Sub-task SPARK-54374 ===
Summary: Enlarge the SVG viewBox attribute of SQL DAG initialization
Assignee: None
Status: Reopened
Affected: ["4.2.0"]
---
*This comment was automatically generated by GitHub Actions*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54374][SQL][UI] Enlarge the SVG viewBox attribute of SQL plan visualization initialization [spark]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #53864:
URL: https://github.com/apache/spark/pull/53864#issuecomment-3895001459
@yaooqinn @sarutak, do you have any ideas on the display issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54374][SQL][UI] Enlarge the SVG viewBox attribute of SQL plan visualization initialization [spark]
Posted by "sarutak (via GitHub)" <gi...@apache.org>.
sarutak commented on PR #53864:
URL: https://github.com/apache/spark/pull/53864#issuecomment-3959127758
@yaooqinn I looked into the issue @pan3793 reported and I noticed that [resizeSvg](https://github.com/apache/spark/blob/master/sql/core/src/main/resources/org/apache/spark/sql/execution/ui/static/spark-sql-viz.js#L153) resizes SVG even without `viewBox`. So I think one of the simple way to fix the issue is just reverting this change. Or, do you have any concern without `viewBox` besides resizing SVG?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org