You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Mark Koudritsky <ka...@gmail.com> on 2014/02/04 01:32:55 UTC
Re: Review Request 17553: Throw when trying to create project inside custom
www dir
> On Jan. 30, 2014, 8:12 p.m., Ian Clelland wrote:
> > src/create.js, line 93
> > <https://reviews.apache.org/r/17553/diff/1/?file=456713#file456713line93>
> >
> > Does this take into account the situation where config_json.lib.www is a relative path?
> >
>
> Mark Koudritsky wrote:
> Good point. Added path.resolve()
> It's not completely clear whether the resolve should be relative to CWD or relative to project path. But since in this case --souce is usually passed from the command line it's likely to be relative to CWD.
Ping
- Mark
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17553/#review33246
-----------------------------------------------------------
On Jan. 30, 2014, 9:37 p.m., Mark Koudritsky wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17553/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2014, 9:37 p.m.)
>
>
> Review request for cordova.
>
>
> Bugs: CB-5947
> https://issues.apache.org/jira/browse/CB-5947
>
>
> Repository: cordova-cli
>
>
> Description
> -------
>
> If a custom www dir is provided and is a parent or the same as the project dir, cordova create fails while trying to create an infinite file hierarchy. Detect and stop in this case.
>
>
> Diffs
> -----
>
> src/create.js 75b2621
>
> Diff: https://reviews.apache.org/r/17553/diff/
>
>
> Testing
> -------
>
> npm test
> cordova create --srouce ...
>
>
> Thanks,
>
> Mark Koudritsky
>
>