[GitHub] [incubator-druid] kamaci commented on a change in pull request #7121: Prohibit Throwables.propagate()

[GitBox <gi...@apache.org>]

kamaci commented on a change in pull request #7121: Prohibit Throwables.propagate()
URL: https://github.com/apache/incubator-druid/pull/7121#discussion_r262050980
 
 

 ##########
 File path: indexing-hadoop/src/main/java/org/apache/druid/indexer/updater/HadoopConverterJob.java
 ##########
 @@ -344,9 +343,7 @@ public DataSegment apply(final Path input)
       }
     }
     catch (InterruptedException | ClassNotFoundException e) {
-      RuntimeException exception = Throwables.propagate(e);
-      throwable = exception;
-      throw exception;
+      throw new RuntimeException(e);
 
 Review comment:
   I may miss something but simply removing this catch clause doesn't let to compile the code:
   
       catch (InterruptedException | ClassNotFoundException e) {
         throw new RuntimeException(e);
       }
   
   Do you mean I should update the code something like that:
   
       catch (InterruptedException | ClassNotFoundException e) {
         RuntimeException r = new RuntimeException(e);
         throwable = r;
         throw r;
       }

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org