You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by "geido (via GitHub)" <gi...@apache.org> on 2023/03/10 16:07:36 UTC

[GitHub] [superset] geido commented on pull request #23286: feat(dashboard): Refactor FiltersBadge

geido commented on PR #23286:
URL: https://github.com/apache/superset/pull/23286#issuecomment-1464031248

   Alignment here looks weird. Should the lens icon be displayed in a non-hover color instead of being fully invisible? In that way the alignment would look better. CC @kasiazjc 
   
   ![Screenshot 2023-03-10 at 16 59 32](https://user-images.githubusercontent.com/60598000/224363562-9572306d-9f8c-4b9e-b496-068684920036.png)
   
   I think the divider should be 1px. It's too thick. Also in the design the values are aligned to the right.
   
   ![Screenshot 2023-03-10 at 17 05 31](https://user-images.githubusercontent.com/60598000/224365000-0ccd6f24-0f0f-4ee8-b68a-d07f31f111cd.png)
   
   Rest looks good!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org