You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "srowen (via GitHub)" <gi...@apache.org> on 2023/02/04 15:23:18 UTC
[GitHub] [spark] srowen commented on a diff in pull request #39879: [SPARK-42336][CORE] Use OpenHashMap instead of HashMap in ResourceAllocator
srowen commented on code in PR #39879:
URL: https://github.com/apache/spark/pull/39879#discussion_r1096549303
##########
core/src/main/scala/org/apache/spark/resource/ResourceAllocator.scala:
##########
@@ -38,11 +37,13 @@ private[spark] trait ResourceAllocator {
* For task resources ([[org.apache.spark.scheduler.ExecutorResourceInfo]]), this value
* can be a multiple, such that each address can be allocated up to [[slotsPerAddress]]
* times.
- *
- * TODO Use [[org.apache.spark.util.collection.OpenHashMap]] instead to gain better performance.
*/
private lazy val addressAvailabilityMap = {
- mutable.HashMap(resourceAddresses.map(_ -> slotsPerAddress): _*)
+ val map: OpenHashMap[String, Int] = new OpenHashMap[String, Int]()
Review Comment:
OK, maybe we shouldn't change this then?
However, if you're looking for optimizations in acquire() and release(), maybe instead of checking contains() and then get()-ing the value, just check once with .getOrElse(address, throw new SparkException(...))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org