[GitHub] [hadoop] virajjasani commented on pull request #5768: HADOOP-15984. Jersey 2.x upgrade

["virajjasani (via GitHub)" <gi...@apache.org>]

virajjasani commented on PR #5768:
URL: https://github.com/apache/hadoop/pull/5768#issuecomment-1605619257

   that's right @pjfanning, my goal this time is to only move forward with next sub-module if we have all tests passing for every single sub-module we have done changes to. 
   for instance, until httpfs and webhdfs tests are all green, there is no point moving forward with next set of sub-modules/modules. i assume it's going to be too many iterations over and over again. i hope we move forward but so far it looks like http client input/error stream related usage in httpfs and webhdfs are also going to need drastic changes. e.g. with jersey 1, we were able to throw any exception from server and let client directly catch it but with jersey 2, we are supposed not supposed to throw exception from server. we can only set 500 http response code and add error msg appropriately, hence now both client and server need to manage this new behavior.
   
   This is going to be massive pain, i can't imagine such change can even be acceptable for minor release (3.4).
   Haven't even started with yarn modules yet, they need guice bridge, which itself didn't work last time with jersey 2, and based on their releases, now they are only releasing new versions that are compatible with jersey 3 only.
   https://mvnrepository.com/artifact/org.glassfish.hk2/guice-bridge (2.6.1 is the only one that can work for us, but it didn't work for our yarn changes last time, i tried with various changes in dependency injection but it was really hopeless without any proper documentation or code references)
   
   Thanks for taking look so far btw @pjfanning !!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org