You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by cfroese <gi...@git.apache.org> on 2017/06/13 14:58:06 UTC
[GitHub] incubator-guacamole-server pull request #95: GUACAMOLE-39: Do not abort VNC/...
GitHub user cfroese opened a pull request:
https://github.com/apache/incubator-guacamole-server/pull/95
GUACAMOLE-39: Do not abort VNC/RDP connection if SFTP fails
Re-implementation in the current code base of the changes in the previous pull request for GUACAMOLE-39. For VNC/RDP connections, this PR now logs the failure rather than aborting the connection. This allows the primary connection to succeed regardless of the secondary SFTP connection.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Hatsize/incubator-guacamole-server graceful-sftp
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-guacamole-server/pull/95.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #95
----
commit eda04b8ef1e016514cb5814dc5f8295b92ee56d0
Author: = <fr...@yahoo.ca>
Date: 2017-06-08T22:16:43Z
GUACAMOLE-39: Do not abort VNC/RDP connection if SFTP fails
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-server pull request #95: GUACAMOLE-39: Do not abort VNC/...
Posted by jmuehlner <gi...@git.apache.org>.
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-server/pull/95#discussion_r121854232
--- Diff: src/common-ssh/ssh.c ---
@@ -285,6 +285,38 @@ static void guac_common_ssh_kbd_callback(const char *name, int name_len,
}
/**
+ * * A handler for SSH client errors which logs the error and can optionally
--- End diff --
Woah, what's happened to this comment? It's all diagonal.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-server pull request #95: GUACAMOLE-39: Do not abort VNC/...
Posted by jmuehlner <gi...@git.apache.org>.
Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-server/pull/95#discussion_r121854188
--- Diff: src/common-ssh/common-ssh/ssh.h ---
@@ -93,12 +94,17 @@ void guac_common_ssh_uninit();
* @param user
* The user to authenticate as, once connected.
*
+ * @param abort_on_error
+ * Whether to automatically and fatally abort if an error occurs whil
--- End diff --
Nitpick: missing an "e" in while. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-server pull request #95: GUACAMOLE-39: Do not abort VNC/...
Posted by cfroese <gi...@git.apache.org>.
Github user cfroese closed the pull request at:
https://github.com/apache/incubator-guacamole-server/pull/95
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-server pull request #95: GUACAMOLE-39: Do not abort VNC/...
Posted by cfroese <gi...@git.apache.org>.
Github user cfroese commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-server/pull/95#discussion_r122257713
--- Diff: src/common-ssh/ssh.c ---
@@ -285,6 +285,38 @@ static void guac_common_ssh_kbd_callback(const char *name, int name_len,
}
/**
+ * * A handler for SSH client errors which logs the error and can optionally
--- End diff --
I wish I could explain that. :) It's fixed now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---