[GitHub] [iceberg] aokolnychyi commented on a diff in pull request #7240: Spark: Close the delete threads pool in some procedures like DeleteOrphan and ExpireSnapshots

["aokolnychyi (via GitHub)" <gi...@apache.org>]

aokolnychyi commented on code in PR #7240:
URL: https://github.com/apache/iceberg/pull/7240#discussion_r1157693597


##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/procedures/ExpireSnapshotsProcedure.java:
##########
@@ -46,6 +47,8 @@ public class ExpireSnapshotsProcedure extends BaseProcedure {
 
   private static final Logger LOG = LoggerFactory.getLogger(ExpireSnapshotsProcedure.class);
 
+  private ExecutorService executorService = null;

Review Comment:
   There is already `executorService` variable in `BaseProcedure` and `modifyIcebergTable()` must already close that executor service if it has been initialized.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org