You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/24 23:32:17 UTC

[GitHub] [airflow] kaxil opened a new pull request #10539: Improve descriptions in OpenAPI Spec file (#10417)

kaxil opened a new pull request #10539:
URL: https://github.com/apache/airflow/pull/10539


   - Fix various typo for "collection"
   - Some grammar
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil merged pull request #10539: Improve descriptions in OpenAPI Spec file

Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #10539:
URL: https://github.com/apache/airflow/pull/10539


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil commented on a change in pull request #10539: Improve descriptions in OpenAPI Spec file

Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #10539:
URL: https://github.com/apache/airflow/pull/10539#discussion_r475965542



##########
File path: airflow/api_connexion/openapi/v1.yaml
##########
@@ -1112,7 +1112,7 @@ paths:
 
   /version:
     get:
-      summary: Get a version information
+      summary: Get Airflow version information

Review comment:
       fixed




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] mik-laj commented on a change in pull request #10539: Improve descriptions in OpenAPI Spec file

Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #10539:
URL: https://github.com/apache/airflow/pull/10539#discussion_r475963657



##########
File path: airflow/api_connexion/openapi/v1.yaml
##########
@@ -1112,7 +1112,7 @@ paths:
 
   /version:
     get:
-      summary: Get a version information
+      summary: Get Airflow version information

Review comment:
       ```suggestion
         summary: Get Airflow version
   ```
   Ideally, this field should be less than 20 characters long.
   
   ![Screenshot 2020-08-25 at 01 36 00](https://user-images.githubusercontent.com/12058428/91106598-5af73780-e673-11ea-9c07-fdf767158f1c.png)
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org