You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/07/01 13:45:33 UTC
[GitHub] [beam] jrmccluskey opened a new pull request #15112: [BEAM-12548] Add examples of Equals and EqualsList to equals_test.go
jrmccluskey opened a new pull request #15112:
URL: https://github.com/apache/beam/pull/15112
Adds examples of the usages of Equals and EqualsList functions to equals_test.go. Covers successful usages with individual expected values, a PCollection of values, and an array/slice of values. Also shows the expected error message on a mismatch.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
`ValidatesRunner` compliance status (on master branch)
--------------------------------------------------------
<table>
<thead>
<tr>
<th>Lang</th>
<th>ULR</th>
<th>Dataflow</th>
<th>Flink</th>
<th>Samza</th>
<th>Spark</th>
<th>Twister2</th>
</tr>
</thead>
<tbody>
<tr>
<td>Go</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/badge/icon">
</a>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
</tr>
<tr>
<td>Java</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_ULR/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_ULR/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/badge/icon?subject=V1">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Streaming/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Streaming/lastCompletedBuild/badge/icon?subject=V1+Streaming">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/badge/icon?subject=V1+Java+11">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2/lastCompletedBuild/badge/icon?subject=V2">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2_Streaming/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2_Streaming/lastCompletedBuild/badge/icon?subject=V2+Streaming">
</a><br>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/badge/icon?subject=Java+8">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/badge/icon?subject=Java+11">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/badge/icon?subject=Portable">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/badge/icon?subject=Portable+Streaming">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Samza/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Samza/lastCompletedBuild/badge/icon?subject=Portable">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/badge/icon?subject=Portable">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/badge/icon?subject=Structured+Streaming">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/badge/icon">
</a>
</td>
</tr>
<tr>
<td>Python</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/badge/icon?subject=V1">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/badge/icon?subject=V2">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/badge/icon?subject=ValCont">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/badge/icon?subject=Portable">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
</tr>
<tr>
<td>XLang</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Dataflow/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Dataflow/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
</tr>
</tbody>
</table>
Examples testing status on various runners
--------------------------------------------------------
<table>
<thead>
<tr>
<th>Lang</th>
<th>ULR</th>
<th>Dataflow</th>
<th>Flink</th>
<th>Samza</th>
<th>Spark</th>
<th>Twister2</th>
</tr>
</thead>
<tbody>
<tr>
<td>Go</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
</tr>
<tr>
<td>Java</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Cron/lastCompletedBuild/badge/icon?subject=V1">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Java11_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Java11_Cron/lastCompletedBuild/badge/icon?subject=V1+Java11">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_Examples_Dataflow_V2/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_Examples_Dataflow_V2/lastCompletedBuild/badge/icon?subject=V2">
</a><br>
</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
</tr>
<tr>
<td>Python</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
</tr>
<tr>
<td>XLang</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
</tr>
</tbody>
</table>
Post-Commit SDK/Transform Integration Tests Status (on master branch)
------------------------------------------------------------------------------------------------
<table>
<thead>
<tr>
<th>Go</th>
<th>Java</th>
<th>Python</th>
</tr>
</thead>
<tbody>
<tr>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/badge/icon?subject=3.6">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/badge/icon?subject=3.7">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/badge/icon?subject=3.8">
</a>
</td>
</tr>
</tbody>
</table>
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
<table>
<thead>
<tr>
<th>---</th>
<th>Java</th>
<th>Python</th>
<th>Go</th>
<th>Website</th>
<th>Whitespace</th>
<th>Typescript</th>
</tr>
</thead>
<tbody>
<tr>
<td>Non-portable</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/badge/icon">
</a><br>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/badge/icon?subject=Tests">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/badge/icon?subject=Lint">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/badge/icon?subject=Docker">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/badge/icon?subject=Docs">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
</tr>
<tr>
<td>Portable</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_GoPortable_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_GoPortable_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
<td>---</td>
<td>---</td>
</tr>
</tbody>
</table>
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] jrmccluskey commented on a change in pull request #15112: [BEAM-12548] Add examples of Equals and EqualsList to equals_test.go
Posted by GitBox <gi...@apache.org>.
jrmccluskey commented on a change in pull request #15112:
URL: https://github.com/apache/beam/pull/15112#discussion_r662538287
##########
File path: sdks/go/pkg/beam/testing/passert/equals_test.go
##########
@@ -130,3 +131,64 @@ func TestEqualsList_Bad(t *testing.T) {
}
}
}
+
+func ExampleEquals() {
+ p, s := beam.NewPipelineWithRoot()
+ col := beam.Create(s, "some", "example", "strings")
+
+ Equals(s, col, "example", "some", "strings")
+ err := ptest.Run(p)
+ fmt.Println(err == nil)
+
+ // Output: true
+}
+
+func ExampleEquals_pcollection() {
+ p, s := beam.NewPipelineWithRoot()
+ col := beam.Create(s, "some", "example", "strings")
+ exp := beam.Create(s, "example", "some", "strings")
+
+ Equals(s, col, exp)
+ err := ptest.Run(p)
+ fmt.Println(err == nil)
+
+ // Output: true
+}
+
+func ExampleEqualsList() {
+ p, s := beam.NewPipelineWithRoot()
+ col := beam.Create(s, "example", "inputs", "here")
+ list := [3]string{"here", "example", "inputs"}
+
+ EqualsList(s, col, list)
+ err := ptest.Run(p)
+ fmt.Println(err == nil)
+
+ // Output: true
+}
+
+func ExampleEqualsList_mismatch() {
+ p, s := beam.NewPipelineWithRoot()
+ col := beam.Create(s, "example", "inputs", "here")
+ list := [3]string{"wrong", "inputs", "here"}
+
+ EqualsList(s, col, list)
+ err := ptest.Run(p)
+ if wrapper, ok := err.(interface{ Unwrap() error }); ok {
+ err = wrapper.Unwrap()
+ }
Review comment:
Change made.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] jrmccluskey commented on pull request #15112: [BEAM-12548] Add examples of Equals and EqualsList to equals_test.go
Posted by GitBox <gi...@apache.org>.
jrmccluskey commented on pull request #15112:
URL: https://github.com/apache/beam/pull/15112#issuecomment-872285847
Run GoPortable PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck merged pull request #15112: [BEAM-12548] Add examples of Equals and EqualsList to equals_test.go
Posted by GitBox <gi...@apache.org>.
lostluck merged pull request #15112:
URL: https://github.com/apache/beam/pull/15112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] jrmccluskey commented on a change in pull request #15112: [BEAM-12548] Add examples of Equals and EqualsList to equals_test.go
Posted by GitBox <gi...@apache.org>.
jrmccluskey commented on a change in pull request #15112:
URL: https://github.com/apache/beam/pull/15112#discussion_r662551820
##########
File path: sdks/go/pkg/beam/testing/passert/equals_test.go
##########
@@ -130,3 +131,69 @@ func TestEqualsList_Bad(t *testing.T) {
}
}
}
+
+func ExampleEquals() {
+ p, s := beam.NewPipelineWithRoot()
+ col := beam.Create(s, "some", "example", "strings")
+
+ Equals(s, col, "example", "some", "strings")
+ err := ptest.Run(p)
+ fmt.Println(err == nil)
+
+ // Output: true
+}
+
+func ExampleEquals_pcollection() {
+ p, s := beam.NewPipelineWithRoot()
+ col := beam.Create(s, "some", "example", "strings")
+ exp := beam.Create(s, "example", "some", "strings")
+
+ Equals(s, col, exp)
+ err := ptest.Run(p)
+ fmt.Println(err == nil)
+
+ // Output: true
+}
+
+func ExampleEqualsList() {
+ p, s := beam.NewPipelineWithRoot()
+ col := beam.Create(s, "example", "inputs", "here")
+ list := [3]string{"here", "example", "inputs"}
+
+ EqualsList(s, col, list)
+ err := ptest.Run(p)
+ fmt.Println(err == nil)
+
+ // Output: true
+}
+
+func unwrapError(err error) error {
+ if wrapper, ok := err.(interface{ Unwrap() error}); ok {
+ err = wrapper.Unwrap()
Review comment:
Changed just to start building that habit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on a change in pull request #15112: [BEAM-12548] Add examples of Equals and EqualsList to equals_test.go
Posted by GitBox <gi...@apache.org>.
lostluck commented on a change in pull request #15112:
URL: https://github.com/apache/beam/pull/15112#discussion_r662533411
##########
File path: sdks/go/pkg/beam/testing/passert/equals_test.go
##########
@@ -130,3 +131,64 @@ func TestEqualsList_Bad(t *testing.T) {
}
}
}
+
+func ExampleEquals() {
+ p, s := beam.NewPipelineWithRoot()
+ col := beam.Create(s, "some", "example", "strings")
+
+ Equals(s, col, "example", "some", "strings")
+ err := ptest.Run(p)
+ fmt.Println(err == nil)
+
+ // Output: true
+}
+
+func ExampleEquals_pcollection() {
+ p, s := beam.NewPipelineWithRoot()
+ col := beam.Create(s, "some", "example", "strings")
+ exp := beam.Create(s, "example", "some", "strings")
+
+ Equals(s, col, exp)
+ err := ptest.Run(p)
+ fmt.Println(err == nil)
+
+ // Output: true
+}
+
+func ExampleEqualsList() {
+ p, s := beam.NewPipelineWithRoot()
+ col := beam.Create(s, "example", "inputs", "here")
+ list := [3]string{"here", "example", "inputs"}
+
+ EqualsList(s, col, list)
+ err := ptest.Run(p)
+ fmt.Println(err == nil)
+
+ // Output: true
+}
+
+func ExampleEqualsList_mismatch() {
+ p, s := beam.NewPipelineWithRoot()
+ col := beam.Create(s, "example", "inputs", "here")
+ list := [3]string{"wrong", "inputs", "here"}
+
+ EqualsList(s, col, list)
+ err := ptest.Run(p)
+ if wrapper, ok := err.(interface{ Unwrap() error }); ok {
+ err = wrapper.Unwrap()
+ }
Review comment:
Consider hiding this in a helper method.
`err = unwrapError(err)`
Unnecessary details can detract from an example's utility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on a change in pull request #15112: [BEAM-12548] Add examples of Equals and EqualsList to equals_test.go
Posted by GitBox <gi...@apache.org>.
lostluck commented on a change in pull request #15112:
URL: https://github.com/apache/beam/pull/15112#discussion_r662542857
##########
File path: sdks/go/pkg/beam/testing/passert/equals_test.go
##########
@@ -130,3 +131,69 @@ func TestEqualsList_Bad(t *testing.T) {
}
}
}
+
+func ExampleEquals() {
+ p, s := beam.NewPipelineWithRoot()
+ col := beam.Create(s, "some", "example", "strings")
+
+ Equals(s, col, "example", "some", "strings")
+ err := ptest.Run(p)
+ fmt.Println(err == nil)
+
+ // Output: true
+}
+
+func ExampleEquals_pcollection() {
+ p, s := beam.NewPipelineWithRoot()
+ col := beam.Create(s, "some", "example", "strings")
+ exp := beam.Create(s, "example", "some", "strings")
+
+ Equals(s, col, exp)
+ err := ptest.Run(p)
+ fmt.Println(err == nil)
+
+ // Output: true
+}
+
+func ExampleEqualsList() {
+ p, s := beam.NewPipelineWithRoot()
+ col := beam.Create(s, "example", "inputs", "here")
+ list := [3]string{"here", "example", "inputs"}
+
+ EqualsList(s, col, list)
+ err := ptest.Run(p)
+ fmt.Println(err == nil)
+
+ // Output: true
+}
+
+func unwrapError(err error) error {
+ if wrapper, ok := err.(interface{ Unwrap() error}); ok {
+ err = wrapper.Unwrap()
Review comment:
Style wise, idiomatic go tends to just return early as needed, rather than trying for a single return.
Nothing wrong with the approach, and doesn't make a difference here but good to know.
Merging all the same though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on a change in pull request #15112: [BEAM-12548] Add examples of Equals and EqualsList to equals_test.go
Posted by GitBox <gi...@apache.org>.
lostluck commented on a change in pull request #15112:
URL: https://github.com/apache/beam/pull/15112#discussion_r662543358
##########
File path: sdks/go/pkg/beam/testing/passert/equals_test.go
##########
@@ -130,3 +131,69 @@ func TestEqualsList_Bad(t *testing.T) {
}
}
}
+
+func ExampleEquals() {
+ p, s := beam.NewPipelineWithRoot()
+ col := beam.Create(s, "some", "example", "strings")
+
+ Equals(s, col, "example", "some", "strings")
+ err := ptest.Run(p)
+ fmt.Println(err == nil)
+
+ // Output: true
+}
+
+func ExampleEquals_pcollection() {
+ p, s := beam.NewPipelineWithRoot()
+ col := beam.Create(s, "some", "example", "strings")
+ exp := beam.Create(s, "example", "some", "strings")
+
+ Equals(s, col, exp)
+ err := ptest.Run(p)
+ fmt.Println(err == nil)
+
+ // Output: true
+}
+
+func ExampleEqualsList() {
+ p, s := beam.NewPipelineWithRoot()
+ col := beam.Create(s, "example", "inputs", "here")
+ list := [3]string{"here", "example", "inputs"}
+
+ EqualsList(s, col, list)
+ err := ptest.Run(p)
+ fmt.Println(err == nil)
+
+ // Output: true
+}
+
+func unwrapError(err error) error {
+ if wrapper, ok := err.(interface{ Unwrap() error}); ok {
+ err = wrapper.Unwrap()
+ }
+ return err
+}
+
+func ExampleEqualsList_mismatch() {
+ p, s := beam.NewPipelineWithRoot()
+ col := beam.Create(s, "example", "inputs", "here")
+ list := [3]string{"wrong", "inputs", "here"}
+
+ EqualsList(s, col, list)
+ err := ptest.Run(p)
+ err = unwrapError(err)
+ fmt.Println(err.Error())
Review comment:
It's not required to call the error message, the fmt.Print* functions are smart enough to pull out the .Error() themselves.
##########
File path: sdks/go/pkg/beam/testing/passert/equals_test.go
##########
@@ -130,3 +131,69 @@ func TestEqualsList_Bad(t *testing.T) {
}
}
}
+
+func ExampleEquals() {
+ p, s := beam.NewPipelineWithRoot()
+ col := beam.Create(s, "some", "example", "strings")
+
+ Equals(s, col, "example", "some", "strings")
+ err := ptest.Run(p)
+ fmt.Println(err == nil)
+
+ // Output: true
+}
+
+func ExampleEquals_pcollection() {
+ p, s := beam.NewPipelineWithRoot()
+ col := beam.Create(s, "some", "example", "strings")
+ exp := beam.Create(s, "example", "some", "strings")
+
+ Equals(s, col, exp)
+ err := ptest.Run(p)
+ fmt.Println(err == nil)
+
+ // Output: true
+}
+
+func ExampleEqualsList() {
+ p, s := beam.NewPipelineWithRoot()
+ col := beam.Create(s, "example", "inputs", "here")
+ list := [3]string{"here", "example", "inputs"}
+
+ EqualsList(s, col, list)
+ err := ptest.Run(p)
+ fmt.Println(err == nil)
+
+ // Output: true
+}
+
+func unwrapError(err error) error {
+ if wrapper, ok := err.(interface{ Unwrap() error}); ok {
+ err = wrapper.Unwrap()
Review comment:
Style wise, idiomatic go tends to just return early as needed, rather than trying for a single return.
Nothing wrong with the approach, and doesn't make a difference here but good to know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] jrmccluskey commented on pull request #15112: [BEAM-12548] Add examples of Equals and EqualsList to equals_test.go
Posted by GitBox <gi...@apache.org>.
jrmccluskey commented on pull request #15112:
URL: https://github.com/apache/beam/pull/15112#issuecomment-872261534
R: @lostluck
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] jrmccluskey commented on a change in pull request #15112: [BEAM-12548] Add examples of Equals and EqualsList to equals_test.go
Posted by GitBox <gi...@apache.org>.
jrmccluskey commented on a change in pull request #15112:
URL: https://github.com/apache/beam/pull/15112#discussion_r662551651
##########
File path: sdks/go/pkg/beam/testing/passert/equals_test.go
##########
@@ -130,3 +131,69 @@ func TestEqualsList_Bad(t *testing.T) {
}
}
}
+
+func ExampleEquals() {
+ p, s := beam.NewPipelineWithRoot()
+ col := beam.Create(s, "some", "example", "strings")
+
+ Equals(s, col, "example", "some", "strings")
+ err := ptest.Run(p)
+ fmt.Println(err == nil)
+
+ // Output: true
+}
+
+func ExampleEquals_pcollection() {
+ p, s := beam.NewPipelineWithRoot()
+ col := beam.Create(s, "some", "example", "strings")
+ exp := beam.Create(s, "example", "some", "strings")
+
+ Equals(s, col, exp)
+ err := ptest.Run(p)
+ fmt.Println(err == nil)
+
+ // Output: true
+}
+
+func ExampleEqualsList() {
+ p, s := beam.NewPipelineWithRoot()
+ col := beam.Create(s, "example", "inputs", "here")
+ list := [3]string{"here", "example", "inputs"}
+
+ EqualsList(s, col, list)
+ err := ptest.Run(p)
+ fmt.Println(err == nil)
+
+ // Output: true
+}
+
+func unwrapError(err error) error {
+ if wrapper, ok := err.(interface{ Unwrap() error}); ok {
+ err = wrapper.Unwrap()
+ }
+ return err
+}
+
+func ExampleEqualsList_mismatch() {
+ p, s := beam.NewPipelineWithRoot()
+ col := beam.Create(s, "example", "inputs", "here")
+ list := [3]string{"wrong", "inputs", "here"}
+
+ EqualsList(s, col, list)
+ err := ptest.Run(p)
+ err = unwrapError(err)
+ fmt.Println(err.Error())
Review comment:
Changed for cleanliness
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org