You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Jason Gerlowski (JIRA)" <ji...@apache.org> on 2018/02/05 04:34:00 UTC

[jira] [Updated] (SOLR-11946) Move bin/solr arg-parsing logic to Java

     [ https://issues.apache.org/jira/browse/SOLR-11946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Gerlowski updated SOLR-11946:
-----------------------------------
    Attachment: SOLR-11946.patch

> Move bin/solr arg-parsing logic to Java
> ---------------------------------------
>
>                 Key: SOLR-11946
>                 URL: https://issues.apache.org/jira/browse/SOLR-11946
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: scripts and tools
>    Affects Versions: master (8.0)
>            Reporter: Jason Gerlowski
>            Priority: Minor
>             Fix For: master (8.0)
>
>         Attachments: SOLR-11946.patch
>
>
> Currently, there is logic in three different places that parses arguments for the {{bin/solr}} scripts.  There is logic in the scripts themselves ({{bin/solr}}, {{bin/solr.cmd}}), and there is logic in Java to parse the arguments sent by the scripts themselves ({{SolrCLI.java}}.
> This creates maintenance burden. It makes it easy for inconsistencies to creep into the scripts (see SOLR-11840).  It adds work when adding/removing/modifying {{bin/solr}} script behavior.  And it forces anyone hoping to improve the scripts to be conversant in both bash and Windows batch scripting.
> It would be a big help if _all_ the argument parsing was done on the Java side, and little or none was done in the scripts themselves.  There are a few situations in which this is difficult, but in no cases is it impossible.
> We should move this logic into Java-land.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org