You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by PaulAngus <gi...@git.apache.org> on 2015/11/18 13:02:13 UTC
[GitHub] cloudstack pull request: Remove extraenous log dir and add catalin...
GitHub user PaulAngus opened a pull request:
https://github.com/apache/cloudstack/pull/1087
Remove extraenous log dir and add catalina.out log rotation.
remove unused /var/log/cloudstack-management directory
add cloudstack-catalina to logrotate.d directory so that /var/log/cloudstack/management/catalina.out is rotated.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PaulAngus/cloudstack master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1087.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1087
----
commit 19e5166b8ce35653d207a3823902d9c2178c35ca
Author: Paul Angus <pa...@shapeblue.com>
Date: 2015-11-16T13:17:03Z
remove unused /var/log/cloudstack-management directory
add cloudstack-catalina to logrotate.d directory so that /var/log/cloudstack/management/catalina.out is rotated
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Remove extraenous log dir and add catalin...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1087#issuecomment-160431621
LGTM, tested on CentOS7:
Logrotate is there:
```
[root@cs1 x86_64]# cat /etc/logrotate.d/cloudstack-catalina
/var/log/cloudstack/management/catalina.out {
copytruncate
daily
rotate 14
compress
missingok
create 0644 cloud cloud
}
```
And this folder is missing (expected):
```
ls -la /var/log/cloudstack-management/
ls: cannot access /var/log/cloudstack-management/: No such file or directory
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Remove extraenous log dir and add catalin...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1087#issuecomment-158874419
LGTM, here's a rpm repo built out of this patch: http://sb.bhaisaab.org/cloudstack/paul-rpmpr-1087/centos/paul-rpmpr-1087/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Remove extraenous log dir and add catalin...
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1087#issuecomment-161975241
@PaulAngus sounds like a reasonable solution to preserve custom logrotate configurations on update. Can you push update the PR to remove commit ec698f5?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Remove extraenous log dir and add catalin...
Posted by PaulAngus <gi...@git.apache.org>.
Github user PaulAngus commented on the pull request:
https://github.com/apache/cloudstack/pull/1087#issuecomment-161780789
So looking at the rpm spec options using +%config(noreplace) will cause a new version of cloudstack-catalina (cloudstack-catalina.rpmnew) to be created if cloudstack-catalina has been edited.
However as the contents of /etc/logrotate.d/ are enumerated and run this would result in both the new and old behaviour both being applied - which seems the worst of all worlds.
Therefore I suggest the orginal PR (without commit ec698f5377ad98ac2a34488a0102c45c2408d089) which will overwrite if the new rpm has an updated value in it [1]; is the lesser of two evils.
[1] http://www-uxsup.csx.cam.ac.uk/~jw35/docs/rpm_config.html
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Remove extraenous log dir and add catalin...
Posted by PaulAngus <gi...@git.apache.org>.
Github user PaulAngus closed the pull request at:
https://github.com/apache/cloudstack/pull/1087
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Remove extraenous log dir and add catalin...
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1087#issuecomment-157709261
@PaulAngus the change looks reasonable. Have you checked upgrading the RPM to ensure that the any modified logrotate configuration files are left alone?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Remove extraenous log dir and add catalin...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1087#issuecomment-160431637
@PaulAngus please respond to the comment by @jburwell. After that we can merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Remove extraenous log dir and add catalin...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1087#issuecomment-175680172
@PaulAngus please rebase against latest master and force push
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Remove extraenous log dir and add catalin...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1087#issuecomment-157693735
@PaulAngus, every PR needs an issue on Apache Jira.
In addition, how did you test your changes? Some input will help us to test it as well.
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Remove extraenous log dir and add catalin...
Posted by PaulAngus <gi...@git.apache.org>.
Github user PaulAngus commented on the pull request:
https://github.com/apache/cloudstack/pull/1087#issuecomment-157708006
Apologies.
https://issues.apache.org/jira/browse/CLOUDSTACK-9073 created
removal of /var/log/cloudstack-management
and addition of catalina log rotation in /etc/logrotate.d/
has been running against 4.5.1 for 2 months with no issues.
updated packaging was built against current master and (centos6 and 7) deployed with files/directories as expected.
Left running overnight /var/log/cloudstack/management/catalina.log seen to rotate and compress previous file.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Remove extraenous log dir and add catalin...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1087#issuecomment-216204381
@PaulAngus can you rebase against latest master and share state of your PR, thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---