You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Miklos Gergely <mg...@hortonworks.com> on 2017/03/07 17:12:33 UTC
Review Request 57383: Log Search Upgrade should modify keystore /
truststore path if it wasn't used
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57383/
-----------------------------------------------------------
Review request for Ambari, Oliver Szabo and Robert Nettleton.
Bugs: AMBARI-20346
https://issues.apache.org/jira/browse/AMBARI-20346
Repository: ambari
Description
-------
The default path for the truststore / keystore in 2.4 was under /etc/security, which may cause permission problems. If the user haven't used the keystore / truststore, and haven't altered the path yet it should be modified upon upgrade to the new default value.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java e244925
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java 3dfc32f
Diff: https://reviews.apache.org/r/57383/diff/1/
Testing
-------
Tested on local cluster by upgrading from 2.4 to 2.5, testing the conditions both that force, and does not force location upgrade.
Thanks,
Miklos Gergely
Re: Review Request 57383: Log Search Upgrade should modify keystore /
truststore path if it wasn't used
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57383/#review168153
-----------------------------------------------------------
Ship it!
Ship It!
- Oliver Szabo
On March 7, 2017, 5:12 p.m., Miklos Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57383/
> -----------------------------------------------------------
>
> (Updated March 7, 2017, 5:12 p.m.)
>
>
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
>
>
> Bugs: AMBARI-20346
> https://issues.apache.org/jira/browse/AMBARI-20346
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The default path for the truststore / keystore in 2.4 was under /etc/security, which may cause permission problems. If the user haven't used the keystore / truststore, and haven't altered the path yet it should be modified upon upgrade to the new default value.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java e244925
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java 3dfc32f
>
>
> Diff: https://reviews.apache.org/r/57383/diff/1/
>
>
> Testing
> -------
>
> Tested on local cluster by upgrading from 2.4 to 2.5, testing the conditions both that force, and does not force location upgrade.
>
>
> Thanks,
>
> Miklos Gergely
>
>
Re: Review Request 57383: Log Search Upgrade should modify keystore /
truststore path if it wasn't used
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57383/#review168294
-----------------------------------------------------------
Ship it!
Ship It!
- Oliver Szabo
On March 8, 2017, 12:33 p.m., Miklos Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57383/
> -----------------------------------------------------------
>
> (Updated March 8, 2017, 12:33 p.m.)
>
>
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
>
>
> Bugs: AMBARI-20346
> https://issues.apache.org/jira/browse/AMBARI-20346
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The default path for the truststore / keystore in 2.4 was under /etc/security, which may cause permission problems. If the user haven't used the keystore / truststore, and haven't altered the path yet it should be modified upon upgrade to the new default value.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java e244925
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java 3dfc32f
>
>
> Diff: https://reviews.apache.org/r/57383/diff/2/
>
>
> Testing
> -------
>
> Tested on local cluster by upgrading from 2.4 to 2.5, testing the conditions both that force, and does not force location upgrade.
>
>
> Thanks,
>
> Miklos Gergely
>
>
Re: Review Request 57383: Log Search Upgrade should modify keystore /
truststore path if it wasn't used
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57383/#review168301
-----------------------------------------------------------
Ship it!
Ship It! thanks for the fix
- Oliver Szabo
On March 8, 2017, 3:29 p.m., Miklos Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57383/
> -----------------------------------------------------------
>
> (Updated March 8, 2017, 3:29 p.m.)
>
>
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
>
>
> Bugs: AMBARI-20346
> https://issues.apache.org/jira/browse/AMBARI-20346
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The default path for the truststore / keystore in 2.4 was under /etc/security, which may cause permission problems. If the user haven't used the keystore / truststore, and haven't altered the path yet it should be modified upon upgrade to the new default value.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java e244925
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py 17c536e
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java 3dfc32f
>
>
> Diff: https://reviews.apache.org/r/57383/diff/3/
>
>
> Testing
> -------
>
> Tested on local cluster by upgrading from 2.4 to 2.5, testing the conditions both that force, and does not force location upgrade.
>
>
> Thanks,
>
> Miklos Gergely
>
>
Re: Review Request 57383: Log Search Upgrade should modify keystore /
truststore path if it wasn't used
Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57383/
-----------------------------------------------------------
(Updated March 8, 2017, 3:29 p.m.)
Review request for Ambari, Oliver Szabo and Robert Nettleton.
Changes
-------
add a small fix for a typo of output config file name
Bugs: AMBARI-20346
https://issues.apache.org/jira/browse/AMBARI-20346
Repository: ambari
Description
-------
The default path for the truststore / keystore in 2.4 was under /etc/security, which may cause permission problems. If the user haven't used the keystore / truststore, and haven't altered the path yet it should be modified upon upgrade to the new default value.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java e244925
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py 17c536e
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java 3dfc32f
Diff: https://reviews.apache.org/r/57383/diff/3/
Changes: https://reviews.apache.org/r/57383/diff/2-3/
Testing
-------
Tested on local cluster by upgrading from 2.4 to 2.5, testing the conditions both that force, and does not force location upgrade.
Thanks,
Miklos Gergely
Re: Review Request 57383: Log Search Upgrade should modify keystore /
truststore path if it wasn't used
Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57383/
-----------------------------------------------------------
(Updated March 8, 2017, 12:33 p.m.)
Review request for Ambari, Oliver Szabo and Robert Nettleton.
Changes
-------
switch equals direction to make sure it doesn't throw NPE
Bugs: AMBARI-20346
https://issues.apache.org/jira/browse/AMBARI-20346
Repository: ambari
Description
-------
The default path for the truststore / keystore in 2.4 was under /etc/security, which may cause permission problems. If the user haven't used the keystore / truststore, and haven't altered the path yet it should be modified upon upgrade to the new default value.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java e244925
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java 3dfc32f
Diff: https://reviews.apache.org/r/57383/diff/2/
Changes: https://reviews.apache.org/r/57383/diff/1-2/
Testing
-------
Tested on local cluster by upgrading from 2.4 to 2.5, testing the conditions both that force, and does not force location upgrade.
Thanks,
Miklos Gergely
Re: Review Request 57383: Log Search Upgrade should modify keystore /
truststore path if it wasn't used
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57383/#review168152
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Nettleton
On March 7, 2017, 5:12 p.m., Miklos Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57383/
> -----------------------------------------------------------
>
> (Updated March 7, 2017, 5:12 p.m.)
>
>
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
>
>
> Bugs: AMBARI-20346
> https://issues.apache.org/jira/browse/AMBARI-20346
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The default path for the truststore / keystore in 2.4 was under /etc/security, which may cause permission problems. If the user haven't used the keystore / truststore, and haven't altered the path yet it should be modified upon upgrade to the new default value.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java e244925
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java 3dfc32f
>
>
> Diff: https://reviews.apache.org/r/57383/diff/1/
>
>
> Testing
> -------
>
> Tested on local cluster by upgrading from 2.4 to 2.5, testing the conditions both that force, and does not force location upgrade.
>
>
> Thanks,
>
> Miklos Gergely
>
>