You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "Chenfx-git (via GitHub)" <gi...@apache.org> on 2023/03/30 06:36:49 UTC
[GitHub] [skywalking] Chenfx-git opened a new issue, #10617: [Bug]
Chenfx-git opened a new issue, #10617:
URL: https://github.com/apache/skywalking/issues/10617
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues.
### Apache SkyWalking Component
Java Agent (apache/skywalking-java)
### What happened
Log4j2 doesn't print traceid. We've seen Log4j2 plugin doesn't enhance mutableLogEvent.
### What you expected to happen
Logs can print traceid in all scenarios.
### How to reproduce
log4j2: Use async tab print log asynchronously(not log4j2.contextSelector=org.apache.logging.log4j.core.async.AsyncLoggerContextSelector) and ENABLE_THREADLOCALS was true, will use mutableLogEvent.
### Anything else
When logEvent is mutableLogEvent , field doesn't containt "_$EnhancedClassField_ws", so it always print traceid "N/A".
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] Superskyyy commented on issue #10617: [Bug] Log4j2 doesn't print traceid(mutableLogEvent)
Posted by "Superskyyy (via GitHub)" <gi...@apache.org>.
Superskyyy commented on issue #10617:
URL: https://github.com/apache/skywalking/issues/10617#issuecomment-1489786321
It's simply not implemented, there's no reason on the "why". However, if you would like to support it, we welcome the contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] Chenfx-git commented on issue #10617: [Bug]
Posted by "Chenfx-git (via GitHub)" <gi...@apache.org>.
Chenfx-git commented on issue #10617:
URL: https://github.com/apache/skywalking/issues/10617#issuecomment-1489779023
Why is it not supported? I see plugin only support log4jLogEvent and ringBufferLogEvent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #10617: [Bug]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng closed issue #10617: [Bug]
URL: https://github.com/apache/skywalking/issues/10617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] Chenfx-git commented on issue #10617: [Bug] Log4j2 doesn't print traceid(mutableLogEvent)
Posted by "Chenfx-git (via GitHub)" <gi...@apache.org>.
Chenfx-git commented on issue #10617:
URL: https://github.com/apache/skywalking/issues/10617#issuecomment-1489793183
I just want to know if there's another reason because log is very important. I can try to support it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #10617: [Bug]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on issue #10617:
URL: https://github.com/apache/skywalking/issues/10617#issuecomment-1489774519
We don't declare we support `mutableLogEvent`. AFAIK.
I think this should not be an issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #10617: [Bug] Log4j2 doesn't print traceid(mutableLogEvent)
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on issue #10617:
URL: https://github.com/apache/skywalking/issues/10617#issuecomment-1489784597
Why should? This is an open-source community. We don't have any responsibility to support anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] Superskyyy commented on issue #10617: [Bug] Log4j2 doesn't print traceid(mutableLogEvent)
Posted by "Superskyyy (via GitHub)" <gi...@apache.org>.
Superskyyy commented on issue #10617:
URL: https://github.com/apache/skywalking/issues/10617#issuecomment-1490760729
> I just want to know if there's another reason because log is very important. I can try to support it.
Nope, I think its just a missing point, feel free to file a PR to support it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org